Remove the performance overhead of showLink property #1557
Conversation
Error: "Trailing spaces not allowed"
src/plots/plots.js
Outdated
| @@ -257,6 +257,8 @@ plots.previousPromises = function(gd) { | |||
| * Add source links to your graph inside the 'showSources' config argument. | |||
| */ | |||
| plots.addLinks = function(gd) { | |||
| if(gd._context.showLink === false) return; | |||
There was a problem hiding this comment.
This could break graphs that have the showSources config option set as it is called below.
So, replacing this line with something like:
if(!gd._context.showLink || !gd._context.showSources) return;would be safer.
Made changes according to code review feedback.
|
Code updated according to the review feedback. |
|
Unfortunately, your latest commit made
|
|
Em, Interesting...I will take a look. Did not run the test locally as I thought it is just a trivial change. |
|
I changed the OR condition into AND: if(!gd._context.showLink && !gd._context.showSources) return;It seems to make sense to me logically, and all tests pass. But please review. Thanks! |
|
I cannot reproduce the errors reported by CI. And it does not have information about test cases and lines. Any suggestion on debugging?
|
|
CI uses an older version of Chrome (54, the latest is 57 I think), so maybe that's the issue. Otherwise, have you tried running all the test suites at once with |
|
The error doesn't look like related to browser version. Yes I run the full jasmine test. And only two noCI cases failed:
|
|
Run all the test cases locally again. All 1850 cases passed this time. So I add some comments to re-trigger the CI check. |
|
@hy9be tests are passing. Looks like the CI failure was intermittent. Our apologies. Great PR. Thanks againg 🎉 Merging. |
A fix for: #1554. Do nothing if showLink is set to be false, to avoid performance overhead caused by measuring and reflows.