Skip to content

Clean data when addTraces is called #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 23, 2015
Merged

Clean data when addTraces is called #140

merged 2 commits into from
Dec 23, 2015

Conversation

mdtusz
Copy link
Contributor

@mdtusz mdtusz commented Dec 22, 2015

The traces being added were missing uid, and as such, wouldn't get drawn. Adding cleanData will add the correct uid to the traces now.

@mdtusz mdtusz mentioned this pull request Dec 22, 2015
Closed
@etpinard
Copy link
Contributor

@mdtusz Looks good.

You'll have to modify the addTraces though:

  • there should be a test checking for the existing uid in the updated data
  • but the expectedData test should not check the content of uid (as it is random)

@etpinard
Copy link
Contributor

💃

mdtusz added a commit that referenced this pull request Dec 23, 2015
@mdtusz
Merge pull request #140 from plotly/scattergl-addtrace
4f037ee 
Clean data when addTraces is called
@mdtusz mdtusz merged commit 4f037ee into master Dec 23, 2015
@mdtusz mdtusz deleted the scattergl-addtrace branch December 23, 2015 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mdtusz @etpinard