Skip to content

js-plotly-tester causing other elements to vanish (Chrome) #513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benjeffery opened this issue May 5, 2016 · 10 comments
Closed

js-plotly-tester causing other elements to vanish (Chrome) #513

benjeffery opened this issue May 5, 2016 · 10 comments
Labels
bug something broken community community contribution

Comments

@benjeffery
Copy link
Contributor

Some unrelated elements are hidden when a plot is created in Chrome.
I've tried to make as minimal test case as possible: https://jsfiddle.net/r5uzc7rd/3/
In the fiddle after 2 seconds js-plotly-tester is removed from the DOM and an element becomes visible.
This element is only hidden when using Chrome (I'm on version 50).
A possible workaround is to put z-index:1 on js-plotly-tester but I don't know if that has other consequences. I think #393 may be related.

@etpinard
Copy link
Contributor

etpinard commented May 5, 2016

Thanks for bringing this up and 🍻 for that very nice reproducible example.

After a quick look on browerstack, this issue seems to be apparent only in Chrome 49 and up.

It is not obvious to me what Chrome dislikes about our svg tester node.

@benjeffery
Copy link
Contributor Author

It is certainly a strange one - if you remove the "transform3d" style on the sibling div, OR remove the "absolute-overlay" div OR remove the z-index on the hidden element then the element is not hidden!

@mdtusz
Copy link
Contributor

mdtusz commented May 9, 2016

I'm not 100% convinced this is a plotly.js bug. @benjeffery if you encounter more strangeness with this, please let us know so if it is on our end, we can solve it.

@mdtusz mdtusz added the community community contribution label May 9, 2016
@benjeffery
Copy link
Contributor Author

Yes, this is not the fault of plotly - this is clearly a browser bug. However plotly could help by including a workaround, such as the z-index on the tester SGV. I'm happy to make a PR for that.

I'm trying to pin down the exact bug to submit a browser issue, but the behaviour is hard to pin down.

@jec99
Copy link

jec99 commented May 26, 2016

I am also experiencing this bug. I'm using Angular Material and if a header is designated as <md-toolbar> it is hidden by Plotly, but if it is written as a <div> it is not. It also interferes with the <md-sidenav> directive. It is not an issue of interference because it does not occur in Firefox. The bug does not occur if the element is set to display: table-group-header;, display: table-row, or a few others, but it does occur with all common display settings.

Edited. Everything is working fine in the latest Chromium snapshot corresponding to the current version of Chrome, which can be found here

@benjeffery
Copy link
Contributor Author

As suggested in the contributing guide, I have made a PR against my fork. Could this be reviewed? I'll then make a PR against this repo. Thanks!

@etpinard
Copy link
Contributor

etpinard commented Jul 14, 2016

@benjeffery your fix comes at a good time. Looks like this issue is happening on FF47 too.

@etpinard
Copy link
Contributor

My mistake. Everything is fine in FF47. I misunderstood what the jsFiddle ⏫ was trying to show.

Even better news: looks like this bug is in fact fixed in Chrome 51.

@etpinard
Copy link
Contributor

fixed via #745

@benjeffery
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken community community contribution
Projects
None yet
Development

No branches or pull requests

4 participants