Skip to content

coloraxes with values for sunburst and treemap #4443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
archmoj opened this issue Dec 26, 2019 · 5 comments · Fixed by #4444
Closed

coloraxes with values for sunburst and treemap #4443

archmoj opened this issue Dec 26, 2019 · 5 comments · Fixed by #4444
Assignees
@archmoj
Labels
feature something new
Milestone
v1.52.0

Comments

@archmoj
Copy link
Contributor

archmoj commented Dec 26, 2019

Shared coloraxes should be implemented for sunburst and treemap.
@archmoj archmoj added bug something broken feature something new labels Dec 26, 2019
@archmoj archmoj self-assigned this Dec 26, 2019
@archmoj archmoj added this to the v1.52.0 milestone Dec 26, 2019
@archmoj archmoj mentioned this issue Dec 26, 2019
Merged
@etpinard etpinard removed the bug something broken label Dec 27, 2019
@etpinard
Copy link
Contributor

Hmm. They seem to work fine already:

https://codepen.io/etpinard/pen/zYxdKRw

@archmoj
Copy link
Contributor Author

archmoj commented Dec 27, 2019

Interesting. So the user have to provide a color array and cannot use values, right?

@etpinard
Copy link
Contributor

Interesting. So the user have to provide a color array and cannot use values, right?

Well, too late for that. You handle the values w/o marker.colors case here:

plotly.js/src/traces/sunburst/calc.js

Lines 203 to 205 in e778644

if(!hasColors) {
colors = hasValues ? trace.values : trace._values;
}

@archmoj archmoj changed the title coloraxes for sunburst and treemap coloraxes with values for sunburst and treemap Dec 30, 2019
@nicolaskruchten
Copy link
Contributor

Does this really belong in the 1.52 milestone?

@etpinard
Copy link
Contributor

etpinard commented Jan 6, 2020

It's done in #4444 - which we'll merge at some point today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@archmoj archmoj

Labels
feature something new
Projects
None yet
Milestone
v1.52.0
3 participants
@nicolaskruchten @etpinard @archmoj