Skip to content

Commit c19e727

Browse files
committed
mv flaky tags from 'describe' -> 'it'
1 parent 2c8a290 commit c19e727

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

test/jasmine/tests/config_test.js

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -548,7 +548,7 @@ describe('config argument', function() {
548548
});
549549
});
550550

551-
describe('@flaky responsive figure', function() {
551+
describe('responsive figure', function() {
552552
var gd, data = [{x: [1, 2, 3, 4], y: [5, 10, 2, 8]}];
553553
var width = 960, height = 800;
554554

@@ -608,30 +608,30 @@ describe('config argument', function() {
608608
gd = parent.childNodes[0];
609609
}
610610

611-
it('should resize when the viewport width/height changes', function(done) {
611+
it('@flaky should resize when the viewport width/height changes', function(done) {
612612
fillParent(1, 1);
613613
Plotly.plot(gd, data, {}, {responsive: true})
614614
.then(testResponsive)
615615
.then(done);
616616
});
617617

618-
it('should still be responsive if the plot is edited', function(done) {
618+
it('@flaky should still be responsive if the plot is edited', function(done) {
619619
fillParent(1, 1);
620620
Plotly.plot(gd, data, {}, {responsive: true})
621621
.then(function() {return Plotly.restyle(gd, 'y[0]', data[0].y[0] + 2);})
622622
.then(testResponsive)
623623
.then(done);
624624
});
625625

626-
it('should still be responsive if the plot is purged and replotted', function(done) {
626+
it('@flaky should still be responsive if the plot is purged and replotted', function(done) {
627627
fillParent(1, 1);
628628
Plotly.plot(gd, data, {}, {responsive: true})
629629
.then(function() {return Plotly.newPlot(gd, data, {}, {responsive: true});})
630630
.then(testResponsive)
631631
.then(done);
632632
});
633633

634-
it('should only have one resize handler when plotted more than once', function(done) {
634+
it('@flaky should only have one resize handler when plotted more than once', function(done) {
635635
fillParent(1, 1);
636636
var cntWindowResize = 0;
637637
window.addEventListener('resize', function() {cntWindowResize++;});
@@ -650,15 +650,15 @@ describe('config argument', function() {
650650
.then(done);
651651
});
652652

653-
it('should become responsive if configured as such via Plotly.react', function(done) {
653+
it('@flaky should become responsive if configured as such via Plotly.react', function(done) {
654654
fillParent(1, 1);
655655
Plotly.plot(gd, data, {}, {responsive: false})
656656
.then(function() {return Plotly.react(gd, data, {}, {responsive: true});})
657657
.then(testResponsive)
658658
.then(done);
659659
});
660660

661-
it('should stop being responsive if configured as such via Plotly.react', function(done) {
661+
it('@flaky should stop being responsive if configured as such via Plotly.react', function(done) {
662662
fillParent(1, 1);
663663
Plotly.plot(gd, data, {}, {responsive: true})
664664
// Check initial size
@@ -676,7 +676,7 @@ describe('config argument', function() {
676676
});
677677

678678
// Testing fancier CSS layouts
679-
it('should resize horizontally in a flexbox when responsive: true', function(done) {
679+
it('@flaky should resize horizontally in a flexbox when responsive: true', function(done) {
680680
parent.style.display = 'flex';
681681
parent.style.flexDirection = 'row';
682682
fillParent(1, 2, function() {
@@ -688,7 +688,7 @@ describe('config argument', function() {
688688
.then(done);
689689
});
690690

691-
it('should resize vertically in a flexbox when responsive: true', function(done) {
691+
it('@flaky should resize vertically in a flexbox when responsive: true', function(done) {
692692
parent.style.display = 'flex';
693693
parent.style.flexDirection = 'column';
694694
fillParent(2, 1, function() {
@@ -700,7 +700,7 @@ describe('config argument', function() {
700700
.then(done);
701701
});
702702

703-
it('should resize in both direction in a grid when responsive: true', function(done) {
703+
it('@flaky should resize in both direction in a grid when responsive: true', function(done) {
704704
var numCols = 2, numRows = 2;
705705
parent.style.display = 'grid';
706706
parent.style.gridTemplateColumns = 'repeat(' + numCols + ', 1fr)';
@@ -712,7 +712,7 @@ describe('config argument', function() {
712712
.then(done);
713713
});
714714

715-
it('should provide a fixed non-zero width/height when autosize/responsive: true and container\' size is zero', function(done) {
715+
it('@flaky should provide a fixed non-zero width/height when autosize/responsive: true and container\' size is zero', function(done) {
716716
fillParent(1, 1, function() {
717717
this.style.display = 'inline-block';
718718
this.style.width = null;
@@ -740,7 +740,7 @@ describe('config argument', function() {
740740

741741
// The following test is to guarantee we're not breaking the existing (although maybe not ideal) behaviour.
742742
// In a future version, one may prefer responsive/autosize:true winning over an explicit width/height when embedded in a webpage.
743-
it('should use the explicitly provided width/height even if autosize/responsive:true', function(done) {
743+
it('@flaky should use the explicitly provided width/height even if autosize/responsive:true', function(done) {
744744
fillParent(1, 1, function() {
745745
this.style.width = '1000px';
746746
this.style.height = '500px';

0 commit comments

Comments
 (0)