aj-proof downward line position loop

etpinard · etpinard · commit 2c8a29049579 · 2018-10-31T16:20:57.000-04:00
diff --git a/src/traces/scattergl/index.js b/src/traces/scattergl/index.js
@@ -402,7 +402,7 @@ function plot(gd, subplot, cdata) {
                         firstptdef += 2;
                     }
                     var lastptdef = srcPos.length - 2;
-                    while(lastptdef > -1 && (isNaN(srcPos[lastptdef]) || isNaN(srcPos[lastptdef + 1]))) {
+                    while(lastptdef > firstptdef && (isNaN(srcPos[lastptdef]) || isNaN(srcPos[lastptdef + 1]))) {
                         lastptdef -= 2;
                     }
                     lineOptions.positions = srcPos.slice(firstptdef, lastptdef + 2);
@@ -446,7 +446,7 @@ function plot(gd, subplot, cdata) {
                         firstptdef += 2;
                     }
                     lastptdef = srcPos.length - 2;
-                    while(lastptdef > -1 && isNaN(srcPos[lastptdef + 1])) {
+                    while(lastptdef > firstptdef && isNaN(srcPos[lastptdef + 1])) {
                         lastptdef -= 2;
                     }
                     if(srcPos[firstptdef + 1] !== 0) {
@@ -463,7 +463,7 @@ function plot(gd, subplot, cdata) {
                         firstptdef += 2;
                     }
                     lastptdef = srcPos.length - 2;
-                    while(lastptdef > -1 && isNaN(srcPos[lastptdef])) {
+                    while(lastptdef > firstptdef && isNaN(srcPos[lastptdef])) {
                         lastptdef -= 2;
                     }
                     if(srcPos[firstptdef] !== 0) {

Original file line number	Diff line number	Diff line change
`@@ -402,7 +402,7 @@ function plot(gd, subplot, cdata) {`
`402`	`402`	`firstptdef += 2;`
`403`	`403`	`}`
`404`	`404`	`var lastptdef = srcPos.length - 2;`
`405`		`- while(lastptdef > -1 && (isNaN(srcPos[lastptdef]) \|\| isNaN(srcPos[lastptdef + 1]))) {`
	`405`	`+ while(lastptdef > firstptdef && (isNaN(srcPos[lastptdef]) \|\| isNaN(srcPos[lastptdef + 1]))) {`
`406`	`406`	`lastptdef -= 2;`
`407`	`407`	`}`
`408`	`408`	`lineOptions.positions = srcPos.slice(firstptdef, lastptdef + 2);`
`@@ -446,7 +446,7 @@ function plot(gd, subplot, cdata) {`
`446`	`446`	`firstptdef += 2;`
`447`	`447`	`}`
`448`	`448`	`lastptdef = srcPos.length - 2;`
`449`		`- while(lastptdef > -1 && isNaN(srcPos[lastptdef + 1])) {`
	`449`	`+ while(lastptdef > firstptdef && isNaN(srcPos[lastptdef + 1])) {`
`450`	`450`	`lastptdef -= 2;`
`451`	`451`	`}`
`452`	`452`	`if(srcPos[firstptdef + 1] !== 0) {`
`@@ -463,7 +463,7 @@ function plot(gd, subplot, cdata) {`
`463`	`463`	`firstptdef += 2;`
`464`	`464`	`}`
`465`	`465`	`lastptdef = srcPos.length - 2;`
`466`		`- while(lastptdef > -1 && isNaN(srcPos[lastptdef])) {`
	`466`	`+ while(lastptdef > firstptdef && isNaN(srcPos[lastptdef])) {`
`467`	`467`	`lastptdef -= 2;`
`468`	`468`	`}`
`469`	`469`	`if(srcPos[firstptdef] !== 0) {`