Support nativeRaster objects in annotation_raster() and raster2uri() #2174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
reviewed
Sep 19, 2022
|
Thanks for reviewing the pull request. Looking forward to using this feature! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nativeRasterobjects allow for a much direct and faster rasterizing. If you want to know better about them and their performance I suggest to check the https://github.com/coolbutuseless/nara package (not on CRAN at least for now).ggplot2 already supports nativeRaster objects through
annotation_raster(), howeverggplotlyfails to render it due to a minor limitation inraster2uri().This small pull request:
I would really appreciate to see this merged, because right now rasterizing large images is a very slow process.
Thanks!