Fix response filepath when contains directory #156
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #26.
What's posted is actually fine (resulting tree in plotly account is what you expect online).
Value
kwargs$filename
is preserved undertoJSON()
but then underpostForm()
some parsing issue generates the double directory prepending... Which in turns propagates tofromJSON()
-- I'm talking about https://github.com/ropensci/plotly/blob/master/R/plotly.R#L107That's why I suggest overwriting
resp$filename
with the initialkwargs$filename
so the returned response is what you expect -- no impact on what's actually sent to plotly (as the web platform).Note that the resulting plotly plot is private by default -- is this what we expect?
/cc @sckott @chriddyp