Skip to content

Fix response filepath when contains directory #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 22, 2015

Conversation

mkcor
Copy link
Contributor

@mkcor mkcor commented Jan 20, 2015

This PR addresses issue #26.

What's posted is actually fine (resulting tree in plotly account is what you expect online).

Value kwargs$filename is preserved under toJSON() but then under postForm() some parsing issue generates the double directory prepending... Which in turns propagates to fromJSON() -- I'm talking about https://github.com/ropensci/plotly/blob/master/R/plotly.R#L107

That's why I suggest overwriting resp$filename with the initial kwargs$filename so the returned response is what you expect -- no impact on what's actually sent to plotly (as the web platform).

Note that the resulting plotly plot is private by default -- is this what we expect?

/cc @sckott @chriddyp

@mkcor
Copy link
Contributor Author

mkcor commented Jan 22, 2015

@theengineear bambi eyes

@theengineear
Copy link

Looks reasonable and it has the tests. 🎉

@mkcor
Copy link
Contributor Author

mkcor commented Jan 22, 2015

Thanks!

Updating version number and NEWS file...

mkcor added a commit that referenced this pull request Jan 22, 2015
Fix response filepath when contains directory
@mkcor mkcor merged commit a2bb0fb into master Jan 22, 2015
@mkcor mkcor deleted the marianne-fix-response-filepath branch January 22, 2015 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants