Upgrade to v1.46 #1506
Merged
Upgrade to v1.46 #1506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… titlefont to title.font in ggplotly()
cpsievert
commented
Apr 3, 2019
cpsievert
commented
Apr 3, 2019
cpsievert
commented
Apr 3, 2019
|
Add tests of warnings thrown for titlefont, and config() (Update: done in 11ba0e0) |
cpsievert
commented
Apr 3, 2019
|
@schloerke looking good now? |
schloerke
approved these changes
Apr 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
These plotly.js releases will require some R changes:
titleattributes linked to strings are now deprecated. Please usetitle.textinstead to fill in your title text [#3276]title*attributes are now deprecated. They moved totitle.*. For example, colorbar.titleside is now colorbar.title.side [#3276]FWIW, I'm pretty sure
layout.title,layout.titlefont,layout[axisid].title,layout[axisid].titlefont,marker.colorbar.title,marker.colorbar.titlefont,marker.colorbar.titleside, and carpet-specific attributes are the only ones effected.ggplotly()leverage the newlayout.titleplacement API.