Skip to content

events that don't emit any data should always have event priority, fixes #1466 #1467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 27, 2019
Merged

events that don't emit any data should always have event priority, fixes #1466 #1467

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5742aae
events that don't emit any data should always have event priority, fi…
cpsievert Feb 16, 2019
a597962
stylistic change
cpsievert Feb 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion R/shiny.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,13 @@ event_data <- function(
parseJSONVal(session$rootScope()$input[[eventID]])
}

priority <- match.arg(priority)
# events that don't emit any data should _always_ be treated with event priority
priority <- if (event %in% c("plotly_doubleclick", "plotly_deselect", "plotly_afterplot")) {
"event"
} else {
match.arg(priority)
}

if (priority == "event") {
# Shiny.setInputValue() is always called with event priority
# so simply return the parse input value
Expand Down