crosstalk should only delete traces that it has added itself #1436
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Crosstalk highlight events work by adding/deleting traces as needed. Currently, the deleting logic removes all traces added after initial render. This change makes it so only the traces added by crosstalk are removed.
Example
In the example below you would expect that a new marker is added to the everytime a point is clicked. Instead, without this change, only a single marker is added (and moves
x
position after every click)Testing Notes
Install
devtools::install_github("ropensci/plotly#1436")
then ensure the example above has the correct behavior