Skip to content

geom_density_2d #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 28, 2019
Merged

geom_density_2d #1445

merged 3 commits into from
Aug 28, 2019

Conversation

kojisposts
Copy link
Contributor

should be a final version!

@kojisposts kojisposts changed the title new geom! geom_density_2d Aug 9, 2019
Copy link
Contributor

@michaelbabyn michaelbabyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one qualm about the name spilling out its thumbnail container but otherwise this looks good to me. 💃

@@ -0,0 +1,166 @@
---
title: geom_density_2d | Examples | Plotly
name: geom_density_2d
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though all the other names in this section have the underscore format I think we should break this name up because it's a bit too long for its container. Maybe geom density_2d?

Screenshot from 2019-08-16 17-10-58

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the function also works without the second underscore, which would look like this. I think it's fine

スクリーンショット 2019-08-27 午後1 46 28

@kojisposts kojisposts merged commit 64af07c into source-design-merge Aug 28, 2019
@kojisposts kojisposts deleted the geom_density_2d branch August 28, 2019 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants