This repository was archived by the owner on Jun 4, 2024. It is now read-only.
Copy paste headers #523
Merged
Copy paste headers #523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| public static toClipboard(e: any, selectedCells: SelectedCells, columns: Columns, data: Data) { | ||
| const selectedRows = R.uniq(R.pluck('row', selectedCells).sort((a, b) => a - b)); | ||
| const selectedCols: any = R.uniq(R.pluck('column', selectedCells).sort((a, b) => a - b)); | ||
|
|
||
| const transposedHeaders = createHeadings(R.pluck('name', columns), getHeaderRows(columns)); |
There was a problem hiding this comment.
When merging in with the hidden columns PR #508, will need to pass both the columns and visibleColumns -- visibleColumns for processing the data / creating the copy/paste info and columns (containing the hidden ones) to determine the number of header rows correctly
Marc-Andre-Rivet
suggested changes
Aug 1, 2019
There was a problem hiding this comment.
Small comment about the incoming master / #508 merge.
Missing the toggle prop for this behavior as defined in the issue
This setting would be set by the Dash developer through a property like “include_headers_on_copy_and_paste=True”.
Marc-Andre-Rivet
approved these changes
Aug 2, 2019
Marc-Andre-Rivet
suggested changes
Aug 2, 2019
Marc-Andre-Rivet
approved these changes
Aug 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #318