Skip to content
This repository was archived by the owner on Jun 4, 2024. It is now read-only.

[WIP] Issue 509 - Hidden Columns Persistence #516

Closed
wants to merge 47 commits into from

Conversation

Marc-Andre-Rivet
Copy link
Contributor

Follow up to #508 (#314).

Save and re-apply the hidden columns from session to session for a given table / page.

Saved hidden columns are applied if hidden_columns prop is left to None. If the value is set, this value overrides the local preferences.

This implementation does not take into consideration

  1. Multiple pages operating on the same table(s)
  2. Does not tackle what persistence means at Dash's level -- this is a beta implementation that only looks at the problem from the table's perspective.

Marc-André Rivet and others added 16 commits July 17, 2019 15:23
- hidden vs. visible columns props at sanitation
# Conflicts:
#	src/dash-table/components/FilterFactory.tsx
#	src/dash-table/components/HeaderFactory.tsx
#	src/dash-table/components/Table/props.ts
#	src/dash-table/derived/filter/map.ts
#	src/dash-table/derived/header/content.tsx
@chriddyp chriddyp temporarily deployed to dash-table-review-pr-516 July 25, 2019 18:04 Inactive
@Marc-Andre-Rivet Marc-Andre-Rivet changed the title 509 persistence Issue 509 - Hidden Columns Persistence Jul 25, 2019
@Marc-Andre-Rivet Marc-Andre-Rivet changed the base branch from master to 314-hidden-columns July 25, 2019 18:04
@Marc-Andre-Rivet Marc-Andre-Rivet changed the title Issue 509 - Hidden Columns Persistence [WIP] Issue 509 - Hidden Columns Persistence Aug 2, 2019
@Marc-Andre-Rivet Marc-Andre-Rivet marked this pull request as ready for review August 2, 2019 19:54
@Marc-Andre-Rivet Marc-Andre-Rivet changed the base branch from 314-hidden-columns to master August 2, 2019 22:11
@Marc-Andre-Rivet Marc-Andre-Rivet deleted the 509-persistence branch September 25, 2019 09:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants