[WIP] Add multi output callback support. #91

T4rk1n · 2018-10-25T18:50:44Z

Tests are gonna fail until a rc version of dash has been released.

pip install dash-renderer==0.19.0rc1 try with dash==0.38.0rc1

src/actions/index.js

T4rk1n

Even without prettier it's still a big diff because I moved a good part of updateProps in a for loop. I commented the part where the changes are.

T4rk1n · 2018-10-25T20:34:15Z

src/actions/index.js

+                    .map(e => e.split('.')[0]);
+            } else {
+                outputIds = [outputIdAndProp.split('.')[0]];
+            }


Create an array of output ids instead of a single output.

src/actions/index.js

T4rk1n · 2018-12-19T18:05:03Z

A few issues I uncovered while trying to fix the tests failures:

test_removing_component_while_its_getting_updated callback output to the parent of the Output Id children, removing the checklist that was there before.

T4rk1n · 2018-12-19T18:16:45Z

I think the Hot-reload breakage is caused by the changes in #108

rmarren1 · 2018-12-19T22:39:35Z

src/actions/index.js

@@ -316,9 +324,12 @@ export function notifyObservers(payload) {
             * of a controller change.
             * for example, perhaps the user has hidden one of the observers
             */
+
+            const {paths} = getState();
+
            if (
                controllersInFutureQueue.length === 0 &&


I don't think controllersInFutureQueue will be correct here, since the controllers variable set above:

const controllers = InputGraph.hasNode(outputIdAndProp) ? InputGraph.dependantsOf(outputIdAndProp) : [];

Would be [] whenever we are doing multiple outputs.

The controllers variable has the required inputs.

Oh I didn't know those comments were posting 😄 Makes sense after reading below

rmarren1 · 2018-12-19T22:39:52Z

src/actions/index.js

            if (
                controllersInFutureQueue.length === 0 &&
-                has(outputComponentId, getState().paths) &&
+                any(e => has(e, paths))(outputIds) &&
                !controllerIsInExistingQueue


Same comment here.

rmarren1 · 2018-12-20T03:41:58Z

src/actions/index.js

                }
+            };
+            if (multi) {
+                Object.entries(data.response).forEach(handleResponse)


could use ramda forEach

rmarren1 · 2018-12-20T04:17:42Z

src/actions/index.js

@@ -390,18 +397,28 @@ function updateOutput(
     * }
     *
     */
+
+    const [outputComponentId, outputProp] = outputIdAndProp.split('.');


I thought this was a mistake at first, but it looks like in the multi-output case it does not matter that these variables are incorrect. Perhaps only create these locals when config.multi_output for readability?

rmarren1 · 2018-12-20T04:38:02Z

src/actions/index.js

@@ -242,7 +242,15 @@ export function notifyObservers(payload) {
        );
        const queuedObservers = [];
        outputObservers.forEach(function filterObservers(outputIdAndProp) {


I found the variable name outputIdAndProp confusing when reading this, since it can now refer to stuff like [output1.children:output2.n_clicks]

rmarren1

Overall looks great, I'm surprised this could be done without a complete overhaul.

rmarren1 · 2018-12-20T04:43:34Z

src/actions/index.js

-            dependency.output.id === outputComponentId &&
-            dependency.output.property === outputProp
+        dependency => {
+            if (config.multi_output) {


Is this just so we can upgrade dash_renderer without upgrading dash?

Yes, the renderer can be updated without dash.

Okay, then if we lock dash-renderer version in dash install requires then we should be good.

Is there a reason to keep config.multi_output now that version locking is done?

chriddyp · 2018-12-20T23:50:13Z

This is really awesome stuff. I'll leave it to others to dig into the code and do a full review, but from a high level I'd really like to see an extensive suite of high-level tests for different arrangements of the dependencies (DAG), timing issues, hide/showing component behaviour, and callback dependency "chains". The set of tests in https://github.com/plotly/dash-renderer/blob/master/tests/test_render.py were the only way that I've maintained sanity while working through refactors and bug fixes.

I've outlined some pseudocode of the types of tests that I would be writing to make sure that all of this tricky behaviour is locked down. There are probably many other scenarios to consider, but hopefully this gets everyone's wheels turning :)

test_single_input_multi_outputs_on_multiple_components

A super simple 1-Many case. Also pushing up the number of outputs past 10 as sometimes there can be weird bugs between 9 and 10 (from one digit to two digits).

N_OUTPUTS = 50

app.layout = html.Div(
    [dcc.Input(id='input', value='dash')] +
    [html.Div(id='output-{}'.format(i)) for i in range(N_OUTPUTS)]
])

@app.callback([Output('output-{}'.format(i), 'children') for i in range(N_OUTPUTS)], [Input('input', 'value')])
def update_output(value):
    call_count.value += 1
    return ['{} - {}'.format(i, value) for i in range(N_OUTPUTS)]

# pseudo-testing code here, but you get the idea
for i in range(N_OUTPUTS):
    self.assertTextEqual(
        'output-{}'.format(i),
        '{} - dash'.format(i)
    )

self.assertEqual(call_count.value, 1)

sendkeys('input', ' hello')
for i in range(N_OUTPUTS):
    self.assertTextEqual(
        'output-{}'.format(i),
        '{} - dash hello'.format(i)
    )

self.assertEqual(call_count.value, 2)

test_multi_outputs_on_single_component

This one is a sanity test that multiple properties on the same component will get updated.

app.layout = html.Div([
    dcc.Input(id='input', value='dash'),
    html.Div(id='output'),
])

@app.callback(
    [Output('output', 'children'),
     Output('output', 'style'),
     Output('output', 'className')],

    [Input('input', 'value')])
def update_output(value):
    call_count.value += 1
    return [
        value,
        {'fontFamily': value},
        value
    ]


# pseudo-testing code here, but you get the idea
self.assertHTMLEqual(
    'output',
    '<div class="dash" style="font-family: dash">dash<div>'
)
self.assertEqual(call_count.value, 1)

sendkeys('input', ' hello')
self.assertHTMLEqual(
    'output',
    '<div class="dash hello" style="font-family: dash hello">dash hello<div>'
)
self.assertEqual(call_count.value, 2)

test_returning_nested_components_that_trigger_other_callbacks

This one tests layouts that generate other components and, when generated, trigger other callbacks. This one also swaps out entire trees, to make sure that all of that state management is clean.

app.layout = html.Div([
    dcc.RadioItems(
        id='input',
        options=[{'label': i, 'value': i} for i in ['tree', 'string']]
        value='tree'
    ),
    html.Div(id='output-1'),
    html.Div(id='middle', children='text in the middle'),
    html.Div(id='output-2'),
])

@app.callback(
    [Output('output-1', 'children'),
     Output('output-2', 'children')],

    [Input('input', 'value')])
def update_output(value):
    call_count.value += 1
    if value == 'tree':
        return [
            html.Div(id='output-1-child', children=[
                html.Div(
                    id='output-1-grandchild-1',
                    children='output 1 grandchild 1'
                ),
                html.Div(
                    id='output-1-grandchild-2',
                    children='output 1 grandchild 2'
                ),
                dcc.Input(id='output-1-input', value='initial value 1'),
                html.Div(id='output-1-grandchild-3')
            ]),

            html.Div(id='output-2-child', children=[
                html.Div(
                    id='output-2-grandchild-1',
                    children='output 2 grandchild 1'
                ),
                html.Div(
                    id='output-2-grandchild-2',
                    children='output 2 grandchild 2'
                ),
                dcc.Input(id='output-2-input', value='initial value 2'),
                html.Div(id='output-2-grandchild-3'),
                html.Div(id='output-2-grandchild-4'),
                html.Div(id='output-2-grandchild-5'),
            ]),

        ]

    else:
        return ['output 1 text', 'output 2 text']


@app.callback(
    [Output('output-1-grandchild-3', 'children'),
     Output('output-2-grandchild-3', 'children')],
    [Input('output-1-input', 'value'), Input('output-2-input', 'value')])
def callback1(value_1, value_2):
    call_counts['callback1'].value += 1
    return [
        'output 1.3 - {} - {}'.format(value_1, value_2),
        'output 2.3 - {} - {}'.format(value_1, value_2),
    ]


@app.callback(
    [Output('output-2-grandchild-4', 'children'),
     Output('output-2-grandchild-5', 'children')],
    [Input('output-2-input', 'value')])
def callback2(value):
    call_counts['callback2'].value += 1
    return [
        html.Div('ggc0 - output 2.4 - {}'.format(value), id='great-grandchild-0')
        html.Div([
            dcc.Input(id='great-grandchild-1', value='ggc1'),
            [html.Div(id='great-grandchild-2'),
             html.Div(id='great-grandchild-3')]
        ])
    ]

@app.callback(
    [Output('great-grandchild-2', 'children'),
     Output('great-grandchild-3', 'children')],
    [Input('great-grandchild-1', 'value')])
def callback3(value):
    call_counts['callback3'].value += 1
    return [
        'ggc2 - {}'.format(value),
        'ggc3 - {}'.format(value),
    ]

def tree_assertions():
    self.assertTextEqual('middle', 'text in the middle')
    self.assertTextEqual('output-1-grandchild-1', 'output 1 grandchild 1')
    self.assertTextEqual('output-1-grandchild-2', 'output 1 grandchild 2')
    self.assertTextEqual('output-2-grandchild-1', 'output 2 grandchild 1')
    self.assertTextEqual('output-2-grandchild-2', 'output 2 grandchild 2')

    self.assertTextEqual('output-1-grandchild-3', 'output 1.3 - initial value 1 - initial value 2')
    self.assertTextEqual('output-2-grandchild-3', 'output 2.3 - initial value 1 - initial value 2')
    self.assertTextEqual('output-2-grandchild-4', 'output 2.4 - initial value 2')
    self.assertTextEqual('great-grandchild-0', 'ggc0 - output 2.4 - initial value 2')
    self.assertTextEqual('great-grandchild-1', 'ggc1')
    self.assertTextEqual('great-grandchild-2', 'ggc2 - ggc1')
    self.assertTextEqual('great-grandchild-3', 'ggc3 - ggc1')

    self.assertEqual(call_counts['callback1'], 1)
    self.assertEqual(call_counts['callback2'], 1)
    self.assertEqual(call_counts['callback3'], 1)

    sendkeys('output-1-input', '!')
    self.assertTextEqual('output-1-grandchild-3', 'output 1.3 - initial value 1! - initial value 2')
    self.assertTextEqual('output-2-grandchild-4', 'output 2.3 - initial value 1! - initial value 2')
    self.assertEqual(call_counts['callback1'], 1)
    self.assertEqual(call_counts['callback2'], 2)
    self.assertEqual(call_counts['callback3'], 1)

    sendkeys('output-2-input', '?')
    self.assertTextEqual('output-1-grandchild-3', 'output 1.3 - initial value 1! - initial value 2?')
    self.assertTextEqual('output-2-grandchild-4', 'output 2.3 - initial value 1! - initial value 2?')
    self.assertTextEqual('output-2-grandchild-4', 'output 2.4 - initial value 2')
    self.assertTextEqual('great-grandchild-0', 'ggc0 - output 2.4 - initial value 2?')
    self.assertTextEqual('great-grandchild-1', 'ggc1')
    self.assertTextEqual('great-grandchild-2', 'ggc2 - ggc1')
    self.assertTextEqual('great-grandchild-3', 'ggc3 - ggc1')    
    self.assertEqual(call_counts['callback1'], 1)
    self.assertEqual(call_counts['callback2'], 3)
    self.assertEqual(call_counts['callback3'], 2)

    sendkeys('great-grandchild-1', '$')
    self.assertTextEqual('great-grandchild-2', 'ggc2 - ggc1$')    self.assertTextEqual('great-grandchild-3', 'ggc3 - ggc1$')
    self.assertEqual(call_counts['callback1'], 1)
    self.assertEqual(call_counts['callback2'], 3)
    self.assertEqual(call_counts['callback3'], 3)

    # reset for the next call
    call_counts['callback1'] = 0
    call_counts['callback2'] = 0
    call_counts['callback3'] = 0

def string_assertions(callcounts):
    self.assertTextEqual('output-1', 'output 1 text')
    self.assertTextEqual('output-2', 'output 2 text')

tree_assertions(1)
click_on_radio_items('input', 'string')
string_assertions()
click_on_radio_items('input', 'tree')
tree_assertions()
click_on_radio_items('input', 'string')
string_assertions()

Callbacks triggering other callbacks.

This set of tests test that multiple outputs can trigger other multiple outputs. There are lots of different DAG shapes that we should consider here (diamonds vs straight lines, etc).

For these, I recommend just drawing out a bunch of different DAG shapes on paper.

Here are some examples of different shapes (each newline represents a different callback)

shape 1 - diamond

A -> [B, C]
[B, C] -> D

shape 2 - grandparent hooking in

A -> [B, C]
[A, B, C] -> D

(D shouldn't update until B and C are finished updating)

shape 3 - multi-gen

A -> [C, E]
B -> [D, F]
[C, D, E, F] -> G

(G shouldn't update until [C, E] and [D, F] have updated)

shape 4 multi-gen with granparent hook

A -> [C, E]
B -> [D, F]
[A, B, C, D, E, F] -> G

shape 5 - multi-gen fan out

A -> [B, C]
B -> [D, E]
C -> [F, G]

+ there's probably many more unique shapes to consider!

Here's an example of how the test for shape 1 might be written.

call_counts = {
    'bc': Value('i', 0),
    'd': Value('i', 0),
}

app.layout = html.Div([
    dcc.Input(id='a', value='a'),
    dcc.Input(id='b'),
    dcc.Input(id='c'),
    dcc.Input(id='d'),
])

@app.callback([Output('b', 'value'), Output('c', 'value')],
              [Input('a', 'value')])
def update_b_c(value):
    call_counts['bc'].value += 1
    return ['b - ({})'.format(value), 'c - ({})'.format(value)]

@app.callback(Output('d', 'value'),
              [Input('b', 'value'), Input('c', 'value')])
def update_d(valueb, valuec):
    call_counts['d'].value += 1
    return 'd - ({}) - ({})'.format(valueb, valuec)


wait_for_text_to_equal('#d', 'd - (b - (a)) - (c - (a))')
wait_for_text_to_equal('#b', 'b - (a)')
wait_for_text_to_equal('#c', 'c - (a)')
self.assert_equal(call_counts['bc'].value, 1)
self.assert_equal(call_counts['d'].value, 1)

sendkeys('b', '!')
wait_for_text_to_equal('#d', 'd - (b - (a)!) - (c - (a))')
wait_for_text_to_equal('#b', 'b - (a)!')
wait_for_text_to_equal('#c', 'c - (a)')
self.assert_equal(call_counts['bc'].value, 1)
self.assert_equal(call_counts['d'].value, 2)

sendkeys('a', '?')
wait_for_text_to_equal('#d', 'd - (b - (a?)!) - (c - (a?))')
wait_for_text_to_equal('#b', 'b - (a?)!')
wait_for_text_to_equal('#c', 'c - (a?)')
self.assert_equal(call_counts['bc'].value, 2)
self.assert_equal(call_counts['d'].value, 3)

Timing issues
There is a fair amount of logic that is used to reject old requests. There should be at least one test that makes sure that this logic still works with multiple outputs, see

dash-renderer/tests/test_render.py

Lines 1490 to 1525 in 657ab92

    
               def test_callbacks_called_multiple_times_and_out_of_order(self): 
        
                   app = Dash(__name__) 
        
                   app.layout = html.Div([ 
        
                       html.Button(id='input', n_clicks=0), 
        
                       html.Div(id='output') 
        
                   ]) 
        
                   call_count = Value('i', 0) 
        
                   @app.callback( 
        
                       Output('output', 'children'), 
        
                       [Input('input', 'n_clicks')]) 
        
                   def update_output(n_clicks): 
        
                       call_count.value = call_count.value + 1 
        
                       if n_clicks == 1: 
        
                           time.sleep(4) 
        
                       return n_clicks 
        
                   self.startServer(app) 
        
                   button = self.wait_for_element_by_css_selector('#input') 
        
                   button.click() 
        
                   button.click() 
        
                   time.sleep(8) 
        
                   self.percy_snapshot( 
        
                       name='test_callbacks_called_multiple_times_and_out_of_order' 
        
                   ) 
        
                   self.assertEqual(call_count.value, 3) 
        
                   self.assertEqual( 
        
                       self.driver.find_element_by_id('output').text, 
        
                       '2' 
        
                   ) 
        
                   request_queue = self.driver.execute_script( 
        
                       'return window.store.getState().requestQueue' 
        
                   ) 
        
                   self.assertFalse(request_queue[0]['rejected']) 
        
                   self.assertEqual(len(request_queue), 1)

.

Hiding components during updates
What happens when a callback returns with an update but a different callback removed that component? This should work with multiple outputs as well, see the single output case here:

dash-renderer/tests/test_render.py

Line 1297 in 657ab92

def test_removing_component_while_its_getting_updated(self):

alexcjohnson · 2019-01-04T22:27:05Z

@T4rk1n it looks like we're not detecting circular dependencies when multi-output callbacks are in the loop. Consider:

app.layout = html.Div([
    dcc.Input(id='a'),
    dcc.Input(id='b'),
    html.P(id='c')
])

@app.callback(Output('a', 'value'), [Input('b', 'value')])
def set_a(b):
    return ((b or '') + 'X')[:100]

# if I use set_b, we detect the loop
@app.callback(Output('b', 'value'), [Input('a', 'value')])
def set_b(a):
    return a

# if I use set_bc and comment out set_b, we don't detect the loop,
# the app runs and eventually fills up with 100 X's
@app.callback([Output('b', 'value'), Output('c', 'children')],
              [Input('a', 'value')])
def set_bc(a):
    return [a, a]

I'm thinking what we need (and will need for #475 as well, though in a somewhat different form) is a second dep graph that expands out the multiple outputs - in the first we (already) make a link:
'a.value' -> 'b.value..c.children' (would we really need the ... bookends at all?)
but in the second we'd make two links:
'a.value' -> 'b.value'
'a.value' -> 'c.children'

T4rk1n · 2019-02-08T00:21:32Z

@alexcjohnson The circular dependency test is now passing.

is a second dep graph that expands out the multiple outputs

That was the winner solution. 🎉

T4rk1n · 2019-02-08T03:52:27Z

There's an error in the style tag of the .Select class that is inserted in head and sent to percy; It contains > in some place instead of spaces so the css appear broken.

alexcjohnson · 2019-02-08T03:55:59Z

There's an error in the style tag of the .Select class that is inserted in head and sent to percy; It contains > in some place instead of spaces so the css appear broken.

Ooh interesting - how did you figure this out? I guess it's the same as in #120? cc @Marc-Andre-Rivet

alexcjohnson · 2019-02-08T04:00:22Z

There's an error in the style tag of the .Select class that is inserted in head and sent to percy;

And the next question, what would it take to fix that? Is it our error, or is it in react-select or one of its neighbors?

T4rk1n · 2019-02-08T04:01:55Z

I downloaded percy sources, open the raw html in a browser, there's no css applied to dropdown unlike when running the test.

In the editor I then see red:

</style><style type="text/css">.Select,.Select-control{position:relative}.Select-control,.Select-input&gt;input

T4rk1n · 2019-02-08T04:11:36Z

And the next question, what would it take to fix that? Is it our error, or is it in react-select or one of its neighbors?

It is our error, before the style was in a style sheet, now it's included in the head, there must something that escape the css .Select > input.

T4rk1n · 2019-02-08T04:49:06Z

The > character is only escaped when it is sent to percy, I contacted percy support.

alexcjohnson · 2019-02-08T14:51:13Z

Thanks @T4rk1n - let’s accept these broken images for now and follow up when we learn more from Percy in https://github.com/plotly/dash-core/issues/43

alexcjohnson

💃 great looking tests. I thought I had a case that could happen with multi-output but not single-output, but on further reflection the case I had in mind isn't possible. So, I think you've got the important ones!

T4rk1n mentioned this pull request Oct 25, 2018

Multi output callbacks support. plotly/dash#436

Merged

3 tasks

chriddyp reviewed Oct 25, 2018

View reviewed changes

src/actions/index.js Show resolved Hide resolved

T4rk1n force-pushed the multi-output branch from efcf256 to 94f009e Compare October 25, 2018 20:22

T4rk1n commented Oct 25, 2018

View reviewed changes

T4rk1n mentioned this pull request Oct 30, 2018

Loading states api #93

Merged

2 tasks

T4rk1n force-pushed the multi-output branch from 888b5a0 to 7a6cb44 Compare December 18, 2018 22:27

rmarren1 reviewed Dec 19, 2018

View reviewed changes

rmarren1 reviewed Dec 20, 2018

View reviewed changes

T4rk1n force-pushed the multi-output branch from cc1e4fd to 441f464 Compare January 8, 2019 20:55

T4rk1n force-pushed the multi-output branch 3 times, most recently from ed9d861 to b366bd3 Compare February 8, 2019 00:02

alexcjohnson approved these changes Feb 20, 2019

View reviewed changes

T4rk1n and others added 20 commits February 20, 2019 15:38

Remove commented line.

114a64b

Object.keys map -> Object.entries, rename k->outputIdAndProp.

521dbdd

Non breaking multi-output.

8154509

🚧 Always get the paths from fresh state.

5355ced

🐛 Filter output that doesn't have any paths left on update return.

27a605e

🔨 Replace test Event callback with Input

cc25a3b

✅ Add test_single_input_multi_outputs_on_multiple_components

fc3da77

⬆️ Update dash from git branch.

fea28d0

✅ Add test_multi_outputs_on_single_component

77dcf97

🔨 Use dot notation for multi-output id

e4b5e1c

✅ Add multi output version of timing issues test.

7580267

✅ Add multi output circular dependency test.

fa209ec

📦 Rebuild bundles/rebased.

0701e4d

🐛 Fix multi-output circular dependencies.

ea5a17f

📦 Rebuild bundles.

cdb571c

🚨 Fix test_initial_state

7b2ffd4

🚨 Fix test_simple_callbacks

98699fe

🚨 Serve css locally.

5deebd0

🔧 Install dcc from fix-select-css branch.

7b2d1e1

📦 Rebuild rebase.

06663c4

T4rk1n force-pushed the multi-output branch from 4930a9a to 06663c4 Compare February 20, 2019 20:42

🔪 Remove multi-output config for backward compat.

6b9de59

T4rk1n force-pushed the multi-output branch from 1f157aa to 6b9de59 Compare February 20, 2019 21:24

alexcjohnson mentioned this pull request Feb 28, 2019

Add 'namespace' and 'type' props to _dash_update_component payload. #69

Closed

alexcjohnson and others added 4 commits February 28, 2019 16:35

Merge branch 'master' into multi-output

b688daf

fix custom hooks test for multi-output

b72c9a8

put dash back to master branch

ed2a485

Merge branch 'master' into multi-output

a25a5a3

alexcjohnson merged commit 608ac7c into master Mar 1, 2019

alexcjohnson deleted the multi-output branch March 1, 2019 19:13

[WIP] Add multi output callback support. #91

[WIP] Add multi output callback support. #91

Uh oh!

Conversation

T4rk1n commented Oct 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

T4rk1n left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

T4rk1n commented Dec 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

T4rk1n commented Dec 19, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rmarren1 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chriddyp commented Dec 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexcjohnson commented Jan 4, 2019

Uh oh!

T4rk1n commented Feb 8, 2019

Uh oh!

T4rk1n commented Feb 8, 2019

Uh oh!

alexcjohnson commented Feb 8, 2019

Uh oh!

alexcjohnson commented Feb 8, 2019

Uh oh!

T4rk1n commented Feb 8, 2019

Uh oh!

T4rk1n commented Feb 8, 2019

Uh oh!

T4rk1n commented Feb 8, 2019

Uh oh!

alexcjohnson commented Feb 8, 2019

Uh oh!

alexcjohnson left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

T4rk1n commented Oct 25, 2018 •

edited

Loading

T4rk1n commented Dec 19, 2018 •

edited

Loading

chriddyp commented Dec 20, 2018 •

edited

Loading