remove publish scripts #622
Conversation
CONTRIBUTING.md
Outdated
| @@ -35,12 +35,10 @@ respectively. TODO: | |||
| * Add `rc1` to `version.py` (`./dash_core_components/version.py`) e.g. `0.13.0rc1` | |||
| * Add `-rc1` to `package.json` e.g. `0.13.0-rc1` | |||
| * Update the `unpkg` link in `./dash_core_components/__init__.py`, replacing `__version__` with your release candidate (e.g. `"0.13.0-rc1"`) | |||
There was a problem hiding this comment.
Do we still want this stuff about prereleases? We've kind of moved away from that model.
Actually I'm wondering if any of this "Publishing New Components/Features" section belongs in the component repos anymore. Since all their versions are locked to Dash, seems like we should move these instructions into the CONTRIBUTING.md in dash instead, as a full step-by-step for first publishing the components - including the whole flow about merging to master, committing bundles there, any sanity checks to make sure these bundles are correct, and how to tag the published version so it can be picked up by Dash for R - and then how to update dash itself and include the new versions of the components.
|
|
||
| 1. Create a pull request and tag the Plotly team (`@plotly/dash`) and tag / request review from [@Marc-Andre-Rivet](https://github.com/Marc-Andre-Rivet) and [@alexcjohnson ](https://github.com/alexcjohnson). | ||
| 2. After a review has been done and your changes have been approved, they will be merged and included in a future release of Dash. | ||
|
|
There was a problem hiding this comment.
Updating contribution guideline everywhere to... open an issue / open a PR, that's it!
These scripts are intended to make publishing more predictable / error-proof, but in reality they mostly get in the way and cause unpredictable behavior at publish time.