Include TEXT1 in generated bins, avoid boot loop #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Arduino 8266 code recently split .text into .text and .text1 to enable placing certain functions in IRAM automatically (required for callbacks in IRQs). Update the binary creation and size calculation to account for this. Without this change, infinite boot loops will occur because the main code will never be uploaded to the chip. Fixes platformio#143
|
Thanks! 😊 |
ivankravets
added a commit
that referenced
this pull request
Apr 14, 2019
This reverts commit 23ea21c.
ivankravets
added a commit
that referenced
this pull request
Apr 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Arduino 8266 code recently split .text into .text and .text1 to
enable placing certain functions in IRAM automatically (required for
callbacks in IRQs).
Update the binary creation and size calculation to account for this.
Without this change, infinite boot loops will occur because the main
code will never be uploaded to the chip.
Fixes #143