refactor!: drop handling of electron arguments #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
May 16, 2022
shadowspawn
approved these changes
May 16, 2022
ruyadorno
approved these changes
May 16, 2022
joesepi
approved these changes
May 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ljharb raised concerns in nodejs/node#42675 that
process.defaultAppis an electron-specific property added toprocess, and not a well known property "blessed" by Node.js itself.I also noticed we have no tests that cover accessing
process.defaultApp.tldr; I think supporting Electron is likely a good call, and we should add this behavior back, but let's do it as a follow on PR, post landing the MVP -- rather than add any additional complexity to nodejs/node#42675.