fix: Improve robustness of the short option error message

aaronccasanova · aaronccasanova · commit 12fd0e6d58fd · 2022-04-12T11:52:01.000-07:00
diff --git a/index.js b/index.js
@@ -93,7 +93,7 @@ function storeOption({
       throw new ERR_UNKNOWN_OPTION(shortOption == null ? `--${longOption}` : `-${shortOption}`);
     }
 
-    const shortOptionErr = optionConfig.short ? `-${optionConfig.short}, ` : '';
+    const shortOptionErr = ObjectHasOwn(optionConfig, 'short') ? `-${optionConfig.short}, ` : '';
 
     if (options[longOption].type === 'string' && optionValue == null) {
       throw new ERR_INVALID_OPTION_VALUE(`Option '${shortOptionErr}--${longOption} <${longOption}>' argument missing`);

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,7 @@ function storeOption({`
`93`	`93`	throw new ERR_UNKNOWN_OPTION(shortOption == null ? `--${longOption}` : `-${shortOption}`);
`94`	`94`	`}`
`95`	`95`
`96`		- const shortOptionErr = optionConfig.short ? `-${optionConfig.short}, ` : '';
	`96`	+ const shortOptionErr = ObjectHasOwn(optionConfig, 'short') ? `-${optionConfig.short}, ` : '';
`97`	`97`
`98`	`98`	`if (options[longOption].type === 'string' && optionValue == null) {`
`99`	`99`	throw new ERR_INVALID_OPTION_VALUE(`Option '${shortOptionErr}--${longOption} <${longOption}>' argument missing`);