-
-
Notifications
You must be signed in to change notification settings - Fork 117
api: introduce net.Listener and net.Conn wrappers #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdc20e9
to
adee7ed
Compare
Signed-off-by: Pires <[email protected]>
Signed-off-by: Pires <[email protected]>
Signed-off-by: Pires <[email protected]>
Signed-off-by: Pires <[email protected]>
Signed-off-by: Pires <[email protected]>
Signed-off-by: Pires <[email protected]>
Signed-off-by: Pires <[email protected]>
Signed-off-by: Pires <[email protected]>
Signed-off-by: Pires <[email protected]>
LGTM, especially with the updated comments from the later commits. It seems this implementation is better than my own wrapper, which is a bit more naive (https://github.com/anisse/proxylistener/blob/master/proxylistener.go) :
In conclusion, LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to partially address #3 with pieces of #2. The reason why I'm not merging #2
(or the code I have here)is because I don't feel confident enough it isn't introducing breaking changes to any existing users of this library who may be pulling from master branch.@Freeaqingme @mgouline @elico @anisse can you PTAL?
TODO
golint
outputaddnet.Dial
example in order to fix An example for a Dialer and Listener is required. #3