[Filter] Do not only allow string on multi select filter.

[martineiber]

Changes in this pull request

Resolves pimcore/studio-backend-bundle#1409

Additional info

[martineiber]

@lukmzig Do you know if there is a reason why we only allow string on multiselect?

[lukmzig]

@lukmzig Do you know if there is a reason why we only allow string on multiselect?

hmmm I think it was just to have a better controller over that modifier itself. I we allow any values, then we also do not need https://github.com/pimcore/generic-data-index-bundle/blob/2.x/src/Model/Search/Modifier/Filter/FieldType/BooleanMultiSelectFilter.php right?
But then should we consider this as a bug?

Another option is to introduce NumberMultiselectFilter and allow integer and floats? Maybe we should discuss the approach here

[martineiber]

@lukmzig
I’d go with that solution and validate against the allowed types (string, int, float):
https://github.com/pimcore/generic-data-index-bundle/blob/2.x/src/Model/Search/Modifier/Filter/FieldType/BooleanMultiSelectFilter.php#L46

This should be considered as a bug? I would say it is an Improvement, since we now allow additional types.

Introducing a NumberMultiSelectFilter would be unnecessary overhead, since the existing MultiSelectFilter already supports numbers. Otherwise, we’d also have to distinguish in Studio whether a value is a string or a number.

WDYT?

[lukmzig]

@lukmzig I’d go with that solution and validate against the allowed types (string, int, float): https://github.com/pimcore/generic-data-index-bundle/blob/2.x/src/Model/Search/Modifier/Filter/FieldType/BooleanMultiSelectFilter.php#L46

Alright, sounds good :) Could you add the validation for the types?

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[lukmzig]

LGTM :)