Add support for Serializer::deserialize #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
jvasseur
reviewed
Feb 13, 2019
|
|
||
| if (substr($objectName, -2) === '[]') { | ||
| // The key type is determined by the data | ||
| return new ArrayType(new MixedType(false), new ObjectType(substr($objectName, 0, -2))); |
There was a problem hiding this comment.
This part sould be recursive as you can define types like this Foo[][] and the denormalizer will handle them.
There was a problem hiding this comment.
You are right of course, #35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return type of deserialize depends on the type you ask it for, so this gets us the correct type.