RenameTestCase to BaseTestCase to prevent import conflicts with PHPUnit's TestCase.

[frankdejonge]

I use auto-complete quite a lot, and although PHPStorm tries to be clever around what class name it will actually import, many time I'm importing PHPStan's test case class instead of PHPUnit's version I intended to import. This causes me to manually remove the import and re-import the intended class.

I hope you'll consider merging this PR 🙏

[ondrejmirtes]

Hi, thanks for this PR. On one hand, I understand why do you want to do this. Renaming it might improve the experience for a lot of users.

On the other hand, I hope you understand the root issue isn't in PHPStan, it's in PhpStorm. PhpStorm is the one behaving badly. It's not PHPStan's fault to have a class named TestCase. There's no real conflict - it's in a different namespace.

But I agree this might be a useful change. I'll merge this for 1.0 in the coming months. I can't merge this now because it's a BC break as pointed out in: https://github.com/phpstan/phpstan-src/pull/634/checks?check_run_id=3382951376

Also this was a useful suggestion: to configure PhpStorm so that it's smarter about autocompletion. https://www.jetbrains.com/help/phpstorm/auto-completing-code.html#ml_completion

[frankdejonge]

Hi @ondrejmirtes,

Great to hear your intention to merge for 1.0. I do agree that it would be great if PHPStorm dealt better with the imports. As far as your suggestion for ML-backed suggestions, I've tried it but in general it made the IDE experience worse for me, unfortunately. If at the time of merging there are conflicts, feel free to ping me and I'll get a fresh one that's ready to merge 👍

[BackEndTea]

This could maybe done without a BC break through a class_alias. Would even give people the option to be compatible with both v 0.12 & 1.0.

But that is a bit more work, so im not sure if thats worth the hassle.

[ondrejmirtes]

If you rebase it now, I'll merge it 😊

[frankdejonge]

On it!

[frankdejonge]

@ondrejmirtes perhaps we should name it PHPStanTestCase since it's also a public facing interface, will make it easier for people who use autocomplete and not want to scroll through 100 BaseTestCase classes.

What do you think?

[frankdejonge]

I've pushed the BaseTestCase => PHPStanTestCase commit, if not desired I can pop it off. Let me know :)

[ondrejmirtes]

Thank you, rebased and merged: 755bd66