fix sscanf() inference with regex format patterns

Author: staabm

src/Type/Php/SscanfFunctionDynamicReturnTypeExtension.php

@@ -45,7 +45,7 @@ public function getTypeFromFunctionCall(
 			return null;
 		}
 
-		if (preg_match_all('/%(\d*)([cdeEfosux]{1})/', $formatType->getValue(), $matches) > 0) {
+		if (preg_match_all('/%(\d*)(\[[^\]]+\]|[cdeEfosux]{1})/', $formatType->getValue(), $matches) > 0) {
 			$arrayBuilder = ConstantArrayTypeBuilder::createEmpty();
 
 			for ($i = 0; $i < count($matches[0]); $i++) {

tests/PHPStan/Analyser/NodeScopeResolverTest.php

@@ -992,6 +992,8 @@ public function dataFileAsserts(): iterable
 			yield from $this->gatherAssertTypes(__DIR__ . '/data/loose-comparisons-php8.php');
 		}
 		yield from $this->gatherAssertTypes(__DIR__ . '/data/loose-comparisons.php');
+		yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-7563.php');
+		yield from $this->gatherAssertTypes(__DIR__ . '/data/bug-7764.php');
 	}
 
 	/**

tests/PHPStan/Analyser/data/bug-7563.php

@@ -0,0 +1,35 @@
+<?php
+
+namespace Bug7563;
+
+declare(strict_types=1);
+
+use function PHPStan\Testing\assertType;
+
+class HelloWorld
+{
+	public static function sayHello(string $dimension): void
+	{
+		$result = sscanf($dimension, '%[1234567890.]%s');
+		assertType('array{string|null, string|null}|null', $result);
+	}
+
+	public static function sayFoo() {
+		$error = 'TYPO3\CMS\Core\Resource\Exception\ExistingTargetFolderException [1423347324] at /var/www/html/app/web/typo3/sysext/core/Classes/Resource/ResourceStorage.php:2496: Folder "1203-0110-0008" already exists.';
+		$exceptionComponents = sscanf($error, '%s [%d] at %[^:]:%d: %[^[]]');
+
+		if (null === $exceptionComponents) {
+			throw new Exception($error);
+		}
+
+		assertType('array{string|null, int|null, string|null, int|null, string|null}', $exceptionComponents);
+	}
+
+	// see https://3v4l.org/Y5T2R
+	public static function edgeCase(string $dimension): void
+	{
+		$result = sscanf($dimension, '%[%[]');
+		assertType('array{string|null}|null', $result);
+	}
+
+}

tests/PHPStan/Analyser/data/bug-7764.php

@@ -0,0 +1,17 @@
+<?php
+
+namespace Bug7764;
+
+use function PHPStan\Testing\assertType;
+
+function doFoo() {
+	$split = sscanf('hello/world', '%[^/]/%[^/]/%s');
+	assertType('array{string|null, string|null, string|null}|null', $split);
+	if (!is_array($split)) {
+		echo 'Not array', "\n";
+	} elseif (count($split) > 1) {
+		echo 'Success', "\n";
+	}
+	print_r($split);
+}
+