Consdier LastConditionVisitor in checkAlwaysTrueCheckTypeFunctionCall-rules

Author: staabm

src/Rules/Comparison/ImpossibleCheckTypeFunctionCallRule.php

@@ -4,6 +4,7 @@
 
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
+use PHPStan\Parser\LastConditionVisitor;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use function sprintf;
@@ -65,6 +66,10 @@ public function processNode(Node $node, Scope $scope): array
 				)))->build(),
 			];
 		} elseif ($this->checkAlwaysTrueCheckTypeFunctionCall) {
+			if ($node->getAttribute(LastConditionVisitor::ATTRIBUTE_NAME) === true) {
+				return [];
+			}
+
 			return [
 				$addTip(RuleErrorBuilder::message(sprintf(
 					'Call to function %s()%s will always evaluate to true.',

src/Rules/Comparison/ImpossibleCheckTypeMethodCallRule.php

@@ -5,6 +5,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Expr;
 use PHPStan\Analyser\Scope;
+use PHPStan\Parser\LastConditionVisitor;
 use PHPStan\Reflection\MethodReflection;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
@@ -65,6 +66,10 @@ public function processNode(Node $node, Scope $scope): array
 				)))->build(),
 			];
 		} elseif ($this->checkAlwaysTrueCheckTypeFunctionCall) {
+			if ($node->getAttribute(LastConditionVisitor::ATTRIBUTE_NAME) === true) {
+				return [];
+			}
+
 			$method = $this->getMethod($node->var, $node->name->name, $scope);
 			return [
 				$addTip(RuleErrorBuilder::message(sprintf(

src/Rules/Comparison/ImpossibleCheckTypeStaticMethodCallRule.php

@@ -5,6 +5,7 @@
 use PhpParser\Node;
 use PhpParser\Node\Expr;
 use PHPStan\Analyser\Scope;
+use PHPStan\Parser\LastConditionVisitor;
 use PHPStan\Reflection\MethodReflection;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
@@ -66,6 +67,10 @@ public function processNode(Node $node, Scope $scope): array
 				)))->build(),
 			];
 		} elseif ($this->checkAlwaysTrueCheckTypeFunctionCall) {
+			if ($node->getAttribute(LastConditionVisitor::ATTRIBUTE_NAME) === true) {
+				return [];
+			}
+
 			$method = $this->getMethod($node->class, $node->name->name, $scope);
 
 			return [

tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeFunctionCallRuleTest.php

@@ -238,6 +238,10 @@ public function testImpossibleCheckTypeFunctionCall(): void
 					'Call to function testIsInt() with int will always evaluate to true.',
 					875,
 				],
+				[
+					'Call to function is_int() with int will always evaluate to true.',
+					889,
+				],
 			],
 		);
 	}

tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeMethodCallRuleEqualsTest.php

@@ -117,6 +117,10 @@ public function testRule(): void
 				'Call to method ImpossibleMethodCall\Foo::isNotSame() with 2 and 2 will always evaluate to false.',
 				194,
 			],
+			[
+				'Call to method ImpossibleMethodCall\ConditionalAlwaysTrue::isInt() with int will always evaluate to true.',
+				208,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeMethodCallRuleTest.php

@@ -149,6 +149,10 @@ public function testRule(): void
 				'Call to method ImpossibleMethodCall\Foo::isNotSame() with 2 and 2 will always evaluate to false.',
 				194,
 			],
+			[
+				'Call to method ImpossibleMethodCall\ConditionalAlwaysTrue::isInt() with int will always evaluate to true.',
+				208,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/Comparison/ImpossibleCheckTypeStaticMethodCallRuleTest.php

@@ -61,6 +61,10 @@ public function testRule(): void
 				'Call to static method PHPStan\Tests\AssertionClass::assertInt() with arguments 1, 2 and 3 will always evaluate to true.',
 				34,
 			],
+			[
+				'Call to static method ImpossibleStaticMethodCall\ConditionalAlwaysTrue::isInt() with int will always evaluate to true.',
+				66,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/Comparison/data/check-type-function-call.php

@@ -876,3 +876,18 @@ function (int $int) {
 
 	}
 };
+
+class ConditionalAlwaysTrue
+{
+	public function sayHello(?int $date): void
+	{
+		if ($date === null) {
+		} elseif (is_int($date)) { // always-true should not be reported because last condition
+		}
+
+		if ($date === null) {
+		} elseif (is_int($date)) { // always-true should be reported, because another condition below
+		} elseif (rand(0,1)) {
+		}
+	}
+}

tests/PHPStan/Rules/Comparison/data/impossible-method-call.php

@@ -195,3 +195,24 @@ public function scalars()
 	}
 
 }
+
+class ConditionalAlwaysTrue
+{
+	public function sayHello(?int $date): void
+	{
+		if ($date === null) {
+		} elseif ($this->isInt($date)) { // always-true should not be reported because last condition
+		}
+
+		if ($date === null) {
+		} elseif ($this->isInt($date)) { // always-true should be reported, because another condition below
+		} elseif (rand(0,1)) {
+		}
+	}
+
+	/**
+	 * @phpstan-assert-if-true int $value
+	 */
+	public function isInt($value): bool {
+	}
+}

tests/PHPStan/Rules/Comparison/data/impossible-static-method-call.php

@@ -53,3 +53,24 @@ public function nullableInt(): ?int
 	}
 
 }
+
+class ConditionalAlwaysTrue
+{
+	public function sayHello(?int $date): void
+	{
+		if ($date === null) {
+		} elseif (self::isInt($date)) { // always-true should not be reported because last condition
+		}
+
+		if ($date === null) {
+		} elseif (self::isInt($date)) { // always-true should be reported, because another condition below
+		} elseif (rand(0,1)) {
+		}
+	}
+
+	/**
+	 * @phpstan-assert-if-true int $value
+	 */
+	static public function isInt($value): bool {
+	}
+}