Consider LastConditionVisitor in ConstantLooseComparisonRule

Author: staabm

src/Rules/Comparison/ConstantLooseComparisonRule.php

@@ -4,6 +4,7 @@
 
 use PhpParser\Node;
 use PHPStan\Analyser\Scope;
+use PHPStan\Parser\LastConditionVisitor;
 use PHPStan\Rules\Rule;
 use PHPStan\Rules\RuleErrorBuilder;
 use PHPStan\Type\Constant\ConstantBooleanType;
@@ -46,6 +47,10 @@ public function processNode(Node $node, Scope $scope): array
 				))->build(),
 			];
 		} elseif ($this->checkAlwaysTrueLooseComparison) {
+			if ($node->getAttribute(LastConditionVisitor::ATTRIBUTE_NAME) === true) {
+				return [];
+			}
+
 			return [
 				RuleErrorBuilder::message(sprintf(
 					'Loose comparison using %s between %s and %s will always evaluate to true.',

tests/PHPStan/Rules/Comparison/ConstantLooseComparisonRuleTest.php

@@ -26,6 +26,14 @@ public function testRule(): void
 				"Loose comparison using == between 0 and '1' will always evaluate to false.",
 				20,
 			],
+			[
+				"Loose comparison using == between 0 and '1' will always evaluate to false.",
+				27,
+			],
+			[
+				"Loose comparison using == between 0 and '1' will always evaluate to false.",
+				33,
+			],
 		]);
 	}
 
@@ -41,6 +49,18 @@ public function testRuleAlwaysTrue(): void
 				"Loose comparison using == between 0 and '1' will always evaluate to false.",
 				20,
 			],
+			[
+				"Loose comparison using == between 0 and '1' will always evaluate to false.",
+				27,
+			],
+			[
+				"Loose comparison using == between 0 and '1' will always evaluate to false.",
+				33,
+			],
+			[
+				"Loose comparison using == between 0 and '0' will always evaluate to true.",
+				35,
+			],
 		]);
 	}
 

tests/PHPStan/Rules/Comparison/data/loose-comparison.php

@@ -22,4 +22,22 @@ public function doFoo(string $s, string $i): void
 		}
 	}
 
+	public function doFooBar(): void
+	{
+		if (0 == "1") {
+
+		} elseif (0 == "0") { // always-true should not be reported because last condition
+
+		}
+
+		if (0 == "1") {
+
+		} elseif (0 == "0") { // always-true should be reported, because another condition below
+
+		} elseif (rand (0, 1)) {
+
+		}
+
+	}
+
 }