[BCB] Changed return types of various methods that had |false to |null

Author: ondrejmirtes

composer.lock

@@ -108,7 +108,7 @@ public function analyseFile(
 							$metadata = [];
 							if ($scope->isInTrait()) {
 								$traitReflection = $scope->getTraitReflection();
-								if ($traitReflection->getFileName() !== false) {
+								if ($traitReflection->getFileName() !== null) {
 									$traitFilePath = $traitReflection->getFileName();
 								}
 							}

src/Analyser/FileAnalyser.php

@@ -292,7 +292,7 @@ public function getFileDescription(): string
 		}
 
 		$traitReflection = $this->context->getTraitReflection();
-		if ($traitReflection->getFileName() === false) {
+		if ($traitReflection->getFileName() === null) {
 			throw new \PHPStan\ShouldNotHappenException();
 		}
 
@@ -2588,7 +2588,7 @@ private function resolveExactName(Name $name): ?string
 					return null;
 				}
 				$currentClassReflection = $this->getClassReflection();
-				if ($currentClassReflection->getParentClass() !== false) {
+				if ($currentClassReflection->getParentClass() !== null) {
 					return $currentClassReflection->getParentClass()->getName();
 				}
 				return null;
@@ -2614,7 +2614,7 @@ public function resolveName(Name $name): string
 				return $this->getClassReflection()->getName();
 			} elseif ($originalClass === 'parent') {
 				$currentClassReflection = $this->getClassReflection();
-				if ($currentClassReflection->getParentClass() !== false) {
+				if ($currentClassReflection->getParentClass() !== null) {
 					return $currentClassReflection->getParentClass()->getName();
 				}
 			}
@@ -3385,7 +3385,7 @@ public function getFunctionType($type, bool $isNullable, bool $isVariadic): Type
 			$className = (string) $type;
 			$lowercasedClassName = strtolower($className);
 			if ($lowercasedClassName === 'parent') {
-				if ($this->isInClass() && $this->getClassReflection()->getParentClass() !== false) {
+				if ($this->isInClass() && $this->getClassReflection()->getParentClass() !== null) {
 					return new ObjectType($this->getClassReflection()->getParentClass()->getName());
 				}
 

src/Analyser/MutatingScope.php

@@ -3663,7 +3663,7 @@ private function processTraitUse(Node\Stmt\TraitUse $node, MutatingScope $classS
 			}
 			$traitReflection = $this->reflectionProvider->getClass($traitName);
 			$traitFileName = $traitReflection->getFileName();
-			if ($traitFileName === false) {
+			if ($traitFileName === null) {
 				continue; // trait from eval or from PHP itself
 			}
 			$fileName = $this->fileHelper->normalizePath($traitFileName);

src/Analyser/NodeScopeResolver.php

@@ -633,7 +633,7 @@ private function getProjectExtensionFiles(?array $projectConfig, array $dependen
 
 					$classReflection = $this->reflectionProvider->getClass($class);
 					$fileName = $classReflection->getFileName();
-					if ($fileName === false) {
+					if ($fileName === null) {
 						continue;
 					}
 

src/Analyser/ResultCache/ResultCacheManager.php

@@ -123,7 +123,7 @@ public function specifyTypesInCondition(
 				} elseif ($lowercasedClassName === 'parent') {
 					if (
 						$scope->isInClass()
-						&& $scope->getClassReflection()->getParentClass() !== false
+						&& $scope->getClassReflection()->getParentClass() !== null
 					) {
 						$type = new ObjectType($scope->getClassReflection()->getParentClass()->getName());
 					} else {

src/Analyser/TypeSpecifier.php

@@ -230,7 +230,7 @@ private function addClassToDependencies(string $className, array &$dependenciesR
 			}
 
 			$classReflection = $classReflection->getParentClass();
-		} while ($classReflection !== false);
+		} while ($classReflection !== null);
 	}
 
 	private function getFunctionReflection(\PhpParser\Node\Name $nameNode, ?Scope $scope): ReflectionWithFilename

src/Dependency/DependencyResolver.php

@@ -41,7 +41,7 @@ public function getFileDependencies(string $currentFile, array $analysedFiles):
 
 		foreach ($this->reflections as $dependencyReflection) {
 			$dependencyFile = $dependencyReflection->getFileName();
-			if ($dependencyFile === false) {
+			if ($dependencyFile === null) {
 				continue;
 			}
 			$dependencyFile = $this->fileHelper->normalizePath($dependencyFile);

src/Dependency/NodeDependencies.php

@@ -341,7 +341,7 @@ private static function getParentReflections(ClassReflection $classReflection):
 		$result = [];
 
 		$parent = $classReflection->getParentClass();
-		if ($parent !== false) {
+		if ($parent !== null) {
 			$result[] = $parent;
 		}
 

src/PhpDoc/PhpDocBlock.php

@@ -310,7 +310,7 @@ private function resolveIdentifierTypeNode(IdentifierTypeNode $typeNode, NameSco
 				case 'parent':
 					if ($this->getReflectionProvider()->hasClass($nameScope->getClassName())) {
 						$classReflection = $this->getReflectionProvider()->getClass($nameScope->getClassName());
-						if ($classReflection->getParentClass() !== false) {
+						if ($classReflection->getParentClass() !== null) {
 							return new ObjectType($classReflection->getParentClass()->getName());
 						}
 					}
@@ -681,7 +681,7 @@ private function resolveConstTypeNode(ConstTypeNode $typeNode, NameScope $nameSc
 					case 'parent':
 						if ($this->getReflectionProvider()->hasClass($nameScope->getClassName())) {
 							$classReflection = $this->getReflectionProvider()->getClass($nameScope->getClassName());
-							if ($classReflection->getParentClass() === false) {
+							if ($classReflection->getParentClass() === null) {
 								return new ErrorType();
 
 							}