Fix wrong message - Instanceof between Xxx and string

Author: lulco

src/Rules/Classes/ImpossibleInstanceOfRule.php

@@ -79,15 +79,15 @@ public function processNode(Node $node, Scope $scope): array
 				$addTip(RuleErrorBuilder::message(sprintf(
 					'Instanceof between %s and %s will always evaluate to false.',
 					$expressionType->describe(VerbosityLevel::typeOnly()),
-					$classType->describe(VerbosityLevel::typeOnly()),
+					$classType->describe(VerbosityLevel::getRecommendedLevelByType($classType)),
 				)))->build(),
 			];
 		} elseif ($this->checkAlwaysTrueInstanceof) {
 			return [
 				$addTip(RuleErrorBuilder::message(sprintf(
 					'Instanceof between %s and %s will always evaluate to true.',
 					$expressionType->describe(VerbosityLevel::typeOnly()),
-					$classType->describe(VerbosityLevel::typeOnly()),
+					$classType->describe(VerbosityLevel::getRecommendedLevelByType($classType)),
 				)))->build(),
 			];
 		}

tests/PHPStan/Rules/Classes/ImpossibleInstanceOfRuleTest.php

@@ -62,7 +62,7 @@ public function testInstanceof(): void
 					94,
 				],
 				[
-					'Instanceof between string and string will always evaluate to false.',
+					'Instanceof between string and \'str\' will always evaluate to false.',
 					98,
 				],
 				[
@@ -169,12 +169,12 @@ public function testInstanceof(): void
 					419,
 				],
 				[
-					'Instanceof between class-string<DateTimeInterface> and string will always evaluate to false.',
+					'Instanceof between class-string<DateTimeInterface> and \'DateTimeInterface\' will always evaluate to false.',
 					432,
 					$tipText,
 				],
 				[
-					'Instanceof between DateTimeInterface and string will always evaluate to true.',
+					'Instanceof between DateTimeInterface and \'DateTimeInterface\' will always evaluate to true.',
 					433,
 					$tipText,
 				],
@@ -200,7 +200,7 @@ public function testInstanceofWithoutAlwaysTrue(): void
 					94,
 				],
 				[
-					'Instanceof between string and string will always evaluate to false.',
+					'Instanceof between string and \'str\' will always evaluate to false.',
 					98,
 				],
 				[
@@ -266,7 +266,7 @@ public function testInstanceofWithoutAlwaysTrue(): void
 					419,
 				],
 				[
-					'Instanceof between class-string<DateTimeInterface> and string will always evaluate to false.',
+					'Instanceof between class-string<DateTimeInterface> and \'DateTimeInterface\' will always evaluate to false.',
 					432,
 					$tipText,
 				],