-
Notifications
You must be signed in to change notification settings - Fork 106
Add integration tests for ODM features #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ondrejmirtes
merged 3 commits into
phpstan:master
from
mcfedr:add-integration-tests-for-odm-features
Feb 12, 2019
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37
tests/DoctrineIntegration/ODM/DocumentManagerIntegrationTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
<?php declare(strict_types = 1); | ||
|
||
namespace PHPStan\DoctrineIntegration\ODM; | ||
|
||
use PHPStan\Testing\LevelsTestCase; | ||
|
||
final class DocumentManagerIntegrationTest extends LevelsTestCase | ||
{ | ||
|
||
/** | ||
* @return string[][] | ||
*/ | ||
public function dataTopics(): array | ||
{ | ||
return [ | ||
['documentManagerDynamicReturn'], | ||
['documentRepositoryDynamicReturn'], | ||
['documentManagerMergeReturn'], | ||
]; | ||
} | ||
|
||
public function getDataPath(): string | ||
{ | ||
return __DIR__ . '/data'; | ||
} | ||
|
||
public function getPhpStanExecutablePath(): string | ||
{ | ||
return __DIR__ . '/../../../vendor/bin/phpstan'; | ||
} | ||
|
||
public function getPhpStanConfigPath(): ?string | ||
{ | ||
return __DIR__ . '/phpstan.neon'; | ||
} | ||
|
||
} |
71 changes: 71 additions & 0 deletions
71
tests/DoctrineIntegration/ODM/data/documentManagerDynamicReturn.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,71 @@ | ||
<?php declare(strict_types = 1); | ||
|
||
namespace PHPStan\DoctrineIntegration\ODM\DocumentManagerDynamicReturn; | ||
|
||
use Doctrine\ODM\MongoDB\DocumentManager; | ||
use Doctrine\ODM\MongoDB\Mapping\Annotations\Document; | ||
use Doctrine\ODM\MongoDB\Mapping\Annotations\Id; | ||
use RuntimeException; | ||
|
||
class Example | ||
{ | ||
/** | ||
* @var DocumentManager | ||
*/ | ||
private $documentManager; | ||
|
||
public function __construct(DocumentManager $documentManager) | ||
{ | ||
$this->documentManager = $documentManager; | ||
} | ||
|
||
public function findDynamicType(): void | ||
{ | ||
$test = $this->documentManager->find(MyDocument::class, 'blah-123'); | ||
|
||
if ($test === null) { | ||
throw new RuntimeException('Sorry, but no...'); | ||
} | ||
|
||
$test->doSomething(); | ||
} | ||
|
||
public function getReferenceDynamicType(): void | ||
{ | ||
$test = $this->documentManager->getReference(MyDocument::class, 'blah-123'); | ||
|
||
if ($test === null) { | ||
throw new RuntimeException('Sorry, but no...'); | ||
} | ||
|
||
$test->doSomething(); | ||
} | ||
|
||
public function getPartialReferenceDynamicType(): void | ||
{ | ||
$test = $this->documentManager->getPartialReference(MyDocument::class, 'blah-123'); | ||
|
||
if ($test === null) { | ||
throw new RuntimeException('Sorry, but no...'); | ||
} | ||
|
||
$test->doSomething(); | ||
} | ||
} | ||
|
||
/** | ||
* @Document() | ||
*/ | ||
class MyDocument | ||
{ | ||
/** | ||
* @Id(strategy="NONE", type="string") | ||
* | ||
* @var string | ||
*/ | ||
private $id; | ||
|
||
public function doSomething(): void | ||
{ | ||
} | ||
} |
43 changes: 43 additions & 0 deletions
43
tests/DoctrineIntegration/ODM/data/documentManagerMergeReturn.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
<?php declare(strict_types = 1); | ||
|
||
namespace PHPStan\DoctrineIntegration\ODM\DocumentManagerMergeReturn; | ||
|
||
use Doctrine\ODM\MongoDB\DocumentManager; | ||
use Doctrine\ODM\MongoDB\Mapping\Annotations\Document; | ||
use Doctrine\ODM\MongoDB\Mapping\Annotations\Id; | ||
|
||
class Example | ||
{ | ||
/** | ||
* @var DocumentManager | ||
*/ | ||
private $documentManager; | ||
|
||
public function __construct(DocumentManager $documentManager) | ||
{ | ||
$this->documentManager = $documentManager; | ||
} | ||
|
||
public function merge(): void | ||
{ | ||
$test = $this->documentManager->merge(new MyDocument()); | ||
$test->doSomething(); | ||
} | ||
} | ||
|
||
/** | ||
* @Document() | ||
*/ | ||
class MyDocument | ||
{ | ||
/** | ||
* @Id(strategy="NONE", type="string") | ||
* | ||
* @var string | ||
*/ | ||
private $id; | ||
|
||
public function doSomething(): void | ||
{ | ||
} | ||
} |
79 changes: 79 additions & 0 deletions
79
tests/DoctrineIntegration/ODM/data/documentRepositoryDynamicReturn.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,79 @@ | ||
<?php declare(strict_types = 1); | ||
|
||
namespace PHPStan\DoctrineIntegration\ODM\DocumentRepositoryDynamicReturn; | ||
|
||
use Doctrine\ODM\MongoDB\DocumentManager; | ||
use Doctrine\ODM\MongoDB\DocumentRepository; | ||
use Doctrine\ODM\MongoDB\Mapping\Annotations\Document; | ||
use Doctrine\ODM\MongoDB\Mapping\Annotations\Id; | ||
use RuntimeException; | ||
|
||
class Example | ||
{ | ||
/** | ||
* @var DocumentRepository | ||
*/ | ||
private $repository; | ||
|
||
public function __construct(DocumentManager $documentManager) | ||
{ | ||
$this->repository = $documentManager->getRepository(MyDocument::class); | ||
} | ||
|
||
public function findDynamicType(): void | ||
{ | ||
$test = $this->repository->find(1); | ||
|
||
if ($test === null) { | ||
throw new RuntimeException('Sorry, but no...'); | ||
} | ||
|
||
$test->doSomething(); | ||
} | ||
|
||
public function findOneByDynamicType(): void | ||
{ | ||
$test = $this->repository->findOneBy(['blah' => 'testing']); | ||
|
||
if ($test === null) { | ||
throw new RuntimeException('Sorry, but no...'); | ||
} | ||
|
||
$test->doSomething(); | ||
} | ||
|
||
public function findAllDynamicType(): void | ||
{ | ||
$items = $this->repository->findAll(); | ||
|
||
foreach ($items as $test) { | ||
$test->doSomething(); | ||
} | ||
} | ||
|
||
public function findByDynamicType(): void | ||
{ | ||
$items = $this->repository->findBy(['blah' => 'testing']); | ||
|
||
foreach ($items as $test) { | ||
$test->doSomething(); | ||
} | ||
} | ||
} | ||
|
||
/** | ||
* @Document() | ||
*/ | ||
class MyDocument | ||
{ | ||
/** | ||
* @Id(strategy="NONE", type="string") | ||
* | ||
* @var string | ||
*/ | ||
private $id; | ||
|
||
public function doSomething(): void | ||
{ | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
includes: | ||
- ../../../extension.neon | ||
|
||
parameters: | ||
doctrine: | ||
repositoryClass: Doctrine\ODM\MongoDB\DocumentRepository |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's this for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doctrine/mongodb-odm
requiresext-mongo
, this tells composer that its installed, even though it isnt, and allows odm to be installedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other option is to run
composer install
with--ignore-platform-reqs
, if you think thats better @ondrejmirtes ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can leave this in :)