Skip to content

Add integration tests for ODM features #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,14 @@
"slevomat/coding-standard": "^4.5.2",
"doctrine/common": "^2.7",
"doctrine/orm": "^2.5",
"doctrine/collections": "^1.0"
"doctrine/collections": "^1.0",
"doctrine/mongodb-odm": "^1.2"
},
"conflict": {
"doctrine/common": "<2.7",
"doctrine/orm": "<2.5",
"doctrine/collections": "<1.0"
"doctrine/collections": "<1.0",
"doctrine/mongodb-odm": "<1.2"
},
"autoload": {
"psr-4": {
Expand All @@ -39,5 +41,10 @@
},
"autoload-dev": {
"classmap": ["tests/"]
},
"config": {
"platform": {
"ext-mongo": "1.6.16"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doctrine/mongodb-odm requires ext-mongo, this tells composer that its installed, even though it isnt, and allows odm to be installed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other option is to run composer install with --ignore-platform-reqs, if you think thats better @ondrejmirtes ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can leave this in :)

}
}
}
37 changes: 37 additions & 0 deletions tests/DoctrineIntegration/ODM/DocumentManagerIntegrationTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
<?php declare(strict_types = 1);

namespace PHPStan\DoctrineIntegration\ODM;

use PHPStan\Testing\LevelsTestCase;

final class DocumentManagerIntegrationTest extends LevelsTestCase
{

/**
* @return string[][]
*/
public function dataTopics(): array
{
return [
['documentManagerDynamicReturn'],
['documentRepositoryDynamicReturn'],
['documentManagerMergeReturn'],
];
}

public function getDataPath(): string
{
return __DIR__ . '/data';
}

public function getPhpStanExecutablePath(): string
{
return __DIR__ . '/../../../vendor/bin/phpstan';
}

public function getPhpStanConfigPath(): ?string
{
return __DIR__ . '/phpstan.neon';
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
<?php declare(strict_types = 1);

namespace PHPStan\DoctrineIntegration\ODM\DocumentManagerDynamicReturn;

use Doctrine\ODM\MongoDB\DocumentManager;
use Doctrine\ODM\MongoDB\Mapping\Annotations\Document;
use Doctrine\ODM\MongoDB\Mapping\Annotations\Id;
use RuntimeException;

class Example
{
/**
* @var DocumentManager
*/
private $documentManager;

public function __construct(DocumentManager $documentManager)
{
$this->documentManager = $documentManager;
}

public function findDynamicType(): void
{
$test = $this->documentManager->find(MyDocument::class, 'blah-123');

if ($test === null) {
throw new RuntimeException('Sorry, but no...');
}

$test->doSomething();
}

public function getReferenceDynamicType(): void
{
$test = $this->documentManager->getReference(MyDocument::class, 'blah-123');

if ($test === null) {
throw new RuntimeException('Sorry, but no...');
}

$test->doSomething();
}

public function getPartialReferenceDynamicType(): void
{
$test = $this->documentManager->getPartialReference(MyDocument::class, 'blah-123');

if ($test === null) {
throw new RuntimeException('Sorry, but no...');
}

$test->doSomething();
}
}

/**
* @Document()
*/
class MyDocument
{
/**
* @Id(strategy="NONE", type="string")
*
* @var string
*/
private $id;

public function doSomething(): void
{
}
}
43 changes: 43 additions & 0 deletions tests/DoctrineIntegration/ODM/data/documentManagerMergeReturn.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
<?php declare(strict_types = 1);

namespace PHPStan\DoctrineIntegration\ODM\DocumentManagerMergeReturn;

use Doctrine\ODM\MongoDB\DocumentManager;
use Doctrine\ODM\MongoDB\Mapping\Annotations\Document;
use Doctrine\ODM\MongoDB\Mapping\Annotations\Id;

class Example
{
/**
* @var DocumentManager
*/
private $documentManager;

public function __construct(DocumentManager $documentManager)
{
$this->documentManager = $documentManager;
}

public function merge(): void
{
$test = $this->documentManager->merge(new MyDocument());
$test->doSomething();
}
}

/**
* @Document()
*/
class MyDocument
{
/**
* @Id(strategy="NONE", type="string")
*
* @var string
*/
private $id;

public function doSomething(): void
{
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
<?php declare(strict_types = 1);

namespace PHPStan\DoctrineIntegration\ODM\DocumentRepositoryDynamicReturn;

use Doctrine\ODM\MongoDB\DocumentManager;
use Doctrine\ODM\MongoDB\DocumentRepository;
use Doctrine\ODM\MongoDB\Mapping\Annotations\Document;
use Doctrine\ODM\MongoDB\Mapping\Annotations\Id;
use RuntimeException;

class Example
{
/**
* @var DocumentRepository
*/
private $repository;

public function __construct(DocumentManager $documentManager)
{
$this->repository = $documentManager->getRepository(MyDocument::class);
}

public function findDynamicType(): void
{
$test = $this->repository->find(1);

if ($test === null) {
throw new RuntimeException('Sorry, but no...');
}

$test->doSomething();
}

public function findOneByDynamicType(): void
{
$test = $this->repository->findOneBy(['blah' => 'testing']);

if ($test === null) {
throw new RuntimeException('Sorry, but no...');
}

$test->doSomething();
}

public function findAllDynamicType(): void
{
$items = $this->repository->findAll();

foreach ($items as $test) {
$test->doSomething();
}
}

public function findByDynamicType(): void
{
$items = $this->repository->findBy(['blah' => 'testing']);

foreach ($items as $test) {
$test->doSomething();
}
}
}

/**
* @Document()
*/
class MyDocument
{
/**
* @Id(strategy="NONE", type="string")
*
* @var string
*/
private $id;

public function doSomething(): void
{
}
}
6 changes: 6 additions & 0 deletions tests/DoctrineIntegration/ODM/phpstan.neon
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
includes:
- ../../../extension.neon

parameters:
doctrine:
repositoryClass: Doctrine\ODM\MongoDB\DocumentRepository