Skip to content

Commit 2029acc

Browse files
committed
Remove doubled condition
Signed-off-by: Kamil Tekiela <[email protected]>
1 parent 867c101 commit 2029acc

File tree

3 files changed

+1
-10
lines changed

3 files changed

+1
-10
lines changed

phpstan-baseline.neon

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -350,11 +350,6 @@ parameters:
350350
count: 8
351351
path: src/Components/OptionsArray.php
352352

353-
-
354-
message: "#^Right side of && is always true\\.$#"
355-
count: 1
356-
path: src/Components/OptionsArray.php
357-
358353
-
359354
message: "#^Property PhpMyAdmin\\\\SqlParser\\\\Components\\\\OrderKeyword\\:\\:\\$expr \\(PhpMyAdmin\\\\SqlParser\\\\Components\\\\Expression\\) does not accept PhpMyAdmin\\\\SqlParser\\\\Components\\\\Expression\\|null\\.$#"
360355
count: 2

psalm-baseline.xml

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -487,10 +487,6 @@
487487
<PossiblyNullPropertyFetch>
488488
<code><![CDATA[$ret->options[$lastOptionId]['expr']->expr]]></code>
489489
</PossiblyNullPropertyFetch>
490-
<RedundantCondition>
491-
<code><![CDATA[! empty($option['equals']) && $option['equals']]]></code>
492-
<code><![CDATA[$option['equals']]]></code>
493-
</RedundantCondition>
494490
<RedundantConditionGivenDocblockType>
495491
<code>$options instanceof self</code>
496492
</RedundantConditionGivenDocblockType>

src/Components/OptionsArray.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -290,7 +290,7 @@ public static function build($component, array $options = []): string
290290
$options[] = $option;
291291
} else {
292292
$options[] = $option['name']
293-
. (! empty($option['equals']) && $option['equals'] ? '=' : ' ')
293+
. (! empty($option['equals']) ? '=' : ' ')
294294
. (! empty($option['expr']) ? $option['expr'] : $option['value']);
295295
}
296296
}

0 commit comments

Comments
 (0)