delete/remove

Author: tatevikg1

src/Domain/Common/Repository/AbstractRepository.php

@@ -46,9 +46,14 @@ public function persist(DomainModel $model): void
      *
      * @return void
      */
-    public function remove(DomainModel $model): void
+    public function delete(DomainModel $model): void
     {
         $this->getEntityManager()->remove($model);
         $this->getEntityManager()->flush();
     }
+
+    public function remove(DomainModel $model): void
+    {
+        $this->getEntityManager()->remove($model);
+    }
 }

src/Domain/Subscription/Service/Manager/SubscribePageManager.php

@@ -33,7 +33,7 @@ public function createPage(string $title, bool $active = false, ?Administrator $
             ->setActive($active)
             ->setOwner($owner);
 
-        $this->pageRepository->save($page);
+        $this->pageRepository->persist($page);
 
         return $page;
     }
@@ -65,15 +65,12 @@ public function updatePage(
             $page->setOwner($owner);
         }
 
-        $this->entityManager->flush();
-
         return $page;
     }
 
     public function setActive(SubscribePage $page, bool $active): void
     {
         $page->setActive($active);
-        $this->entityManager->flush();
     }
 
     public function deletePage(SubscribePage $page): void

tests/Unit/Domain/Subscription/Service/Manager/SubscribePageManagerTest.php

@@ -42,7 +42,7 @@ public function testCreatePageCreatesAndSaves(): void
         $owner = new Administrator();
         $this->pageRepository
             ->expects($this->once())
-            ->method('save')
+            ->method('persist')
             ->with($this->isInstanceOf(SubscribePage::class));
 
         $page = $this->manager->createPage('My Page', true, $owner);
@@ -91,7 +91,7 @@ public function testUpdatePageUpdatesProvidedFieldsAndFlushes(): void
             ->setOwner($originalOwner);
 
         $this->entityManager
-            ->expects($this->once())
+            ->expects($this->never())
             ->method('flush');
 
         $updated = $this->manager->updatePage($page, title: 'New Title', active: true, owner: $newOwner);
@@ -111,7 +111,7 @@ public function testUpdatePageLeavesNullFieldsUntouched(): void
             ->setOwner($owner);
 
         $this->entityManager
-            ->expects($this->once())
+            ->expects($this->never())
             ->method('flush');
 
         $updated = $this->manager->updatePage(page: $page, title: null, active: null, owner: null);
@@ -121,14 +121,14 @@ public function testUpdatePageLeavesNullFieldsUntouched(): void
         $this->assertSame($owner, $updated->getOwner());
     }
 
-    public function testSetActiveSetsFlagAndFlushes(): void
+    public function testSetActiveSetsFlagButNDoesotFlush(): void
     {
         $page = (new SubscribePage())
             ->setTitle('Any')
             ->setActive(false);
 
         $this->entityManager
-            ->expects($this->once())
+            ->expects($this->never())
             ->method('flush');
 
         $this->manager->setActive($page, true);