Fix method tag for longer method names

[danrot]

I have added a testcase that currently fails, although it shouldn't. There seems to be a problem with @method annotations, when the method name gets a little bit longer. According to Regex101 it seems to result in a catastrophic backtrack, which gives me the feeling that this regex is too complicated. I tried to simplify it, but couldn't find any solution that generally worked.

The problem is this regex, if anybody has an idea how to improve it, I am happy to implement it.

[jaapio]

Thanks for this test case, I cannot make any promises when this is fixed. But it looks like an interesting improvement first hand.

[danrot]

Just FYI: This is happening when using the Gedmo Doctrine Extensions, which will make in turn Prophecy fail when trying to mock one of these classes... So I could imagine that this error affects more people.

If anybody could give me a hint I might be able to investigate further.

Other question: If regular expressions seem to be so problematic in that regard, would it be ok to solve this with some PHP code instead?

[mvriel]

Other question: If regular expressions seem to be so problematic in that regard, would it be ok to solve this with some PHP code instead?

That would need to be thoroughly benchmarked; this component uses regex's extensive as they are very performant. This library is used in a tight loop and for some consumers thousands of times; performance is essential.

[danrot]

Other question: If regular expressions seem to be so problematic in that regard, would it be ok to solve this with some PHP code instead?

That would need to be thoroughly benchmarked; this component uses regex's extensive as they are very performant. This library is used in a tight loop and for some consumers thousands of times; performance is essential.

But as far as I can see this call is failing because of performance issues (it seems just as if PHP stops execution of the regex, because it runs into some limit), as soon as the method name gets a little bit longer. And I am not talking about unreasonably long here, a few characters are already enough.

[mvriel]

I cannot answer that question without diving into the code, for which I do not have time at this moment. I can only say, that as a design philosophy this library relies on regular expressions.

They are generally more performant than most PHP-based solutions that we have explored in the past and changing this to a purely based PHP solution should be benchmarked to prevent a performance regression.

I am currently assuming that the issue that you encounter has to do with an error in the regex; I may be proven wrong.

[danrot]

As said, I am also happy to fix this using regular expressions. However, I was not able to until now. So any tips are appreciated 🙂

[rvanvelzen]

Adjusting the regex like this should help.

[danrot]

@rvanvelzen Didn't know about possessive quantifiers so far! Thank you very much, all tests are succeeding now for me 🙂

[mvriel]

@rvanvelzen you are a true regex wizard; I am in awe of your skills :)

[mvriel]

@danrot thanks for reporting the issue and make this happen

[danrot]

@mvriel Happy to give back from time to time 🙂