Skip to content

Commit 2f8def7

Browse files
authored
Merge pull request #193 from asgrim/include-old-pear-convention-for-prebuilt-source-packages
Allow old PEAR/PECL named convention packages for pre-packaged source
2 parents 1b22e9c + 0ff244e commit 2f8def7

File tree

3 files changed

+9
-0
lines changed

3 files changed

+9
-0
lines changed

src/Platform/PrePackagedSourceAssetName.php

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ private function __construct()
2121
public static function packageNames(Package $package): array
2222
{
2323
return [
24+
// Ideal format for new PIE packages
2425
strtolower(sprintf(
2526
'php_%s-%s-src.tgz',
2627
$package->extensionName()->name(),
@@ -31,6 +32,12 @@ public static function packageNames(Package $package): array
3132
$package->extensionName()->name(),
3233
$package->version(),
3334
)),
35+
// Old PEAR/PECL convention
36+
strtolower(sprintf(
37+
'%s-%s.tgz',
38+
$package->extensionName()->name(),
39+
$package->version(),
40+
)),
3441
];
3542
}
3643
}

test/unit/Downloading/DownloadUrlMethodTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ public function testPrePackagedSourceDownloads(): void
9090
[
9191
'php_bar-1.2.3-src.tgz',
9292
'php_bar-1.2.3-src.zip',
93+
'bar-1.2.3.tgz',
9394
],
9495
$downloadUrlMethod->possibleAssetNames($package, $targetPlatform),
9596
);

test/unit/Platform/PrePackagedSourceAssetNameTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ public function testPackageNames(): void
2121
[
2222
'php_foobar-1.2.3-src.tgz',
2323
'php_foobar-1.2.3-src.zip',
24+
'foobar-1.2.3.tgz',
2425
],
2526
PrePackagedSourceAssetName::packageNames(
2627
new Package(

0 commit comments

Comments
 (0)