Skip to content

Fix leaking enum values in property initializers #8177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix leaking enum values in property initializers #8177

wants to merge 1 commit into from

Conversation

bwoebi
Copy link
Member

@bwoebi bwoebi commented Mar 7, 2022

Fixing #8176 - running CI...

iluuu1994
iluuu1994 approved these changes Mar 7, 2022
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you wanna target PHP 8.1?

@bwoebi bwoebi changed the base branch from master to PHP-8.1 March 7, 2022 10:49
@bwoebi
Copy link
Member Author

bwoebi commented Mar 7, 2022

Yes, I do. Based the branch of 8.1, but github is not "smart" enough to realize that and default to the nearest upstream branch or such and I haven't paid attention while creating the PR.

@bwoebi
Copy link
Member Author

bwoebi commented Mar 7, 2022

Merged as cbbf350

@bwoebi bwoebi closed this Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwoebi @iluuu1994