Apply consistent whitespace syntax to the php.ini files #7643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not strongly opposed to these whitespace changes, but I wouldn't target a stable branch. |
|
7.4 is not security only, and i think good consistent ini files easily diffable between versions is a very good thing to have. I actually have them formatted down to 7.2 in my fork.. |
|
This should not go into any branch, only to master. And definitely not into PHP 7.4. IMO, this is a pointless introduction of changes for the sake of changes. |
|
Targeting master makes no sense to me. If you are comfortable shipping such an important file so untidy keep it as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.