Fix #80137: skip getprotobyname() and getprotobynumber() tests on *nix if there is no /etc/protocols file #6193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s no /etc/protocols file
staabm
reviewed
Sep 23, 2020
| @@ -2,6 +2,12 @@ | |||
| getprotobyname function basic test | |||
| --CREDITS-- | |||
| edgarsandi - <[email protected]> | |||
| --SKIPIF-- | |||
| <?php | |||
| if(in_array(PHP_OS_FAMILY, ['BSD', 'Darwin', 'Solaris', 'Linux'])){ | |||
There was a problem hiding this comment.
couldn't you just do the feature detect without this OS whitelist?
There was a problem hiding this comment.
I've added the OS whitelist to prevent the test from being skipped on Windows and others (PHP_OS_FAMILY=Unknown). As far as I know only *nix has the /etc/protocols file which is read by C getprotobyname / getprotobynumber.
nikic
approved these changes
Sep 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix proposal for https://bugs.php.net/bug.php?id=80137
Skip failing tests on *nix if there is no /etc/protocols file.