Skip to content

Autotools: Refactor PCRE JIT checks #14781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2024
Merged

Autotools: Refactor PCRE JIT checks #14781

merged 1 commit into from
Jul 3, 2024

Conversation

petk
Copy link
Member

@petk petk commented Jul 3, 2024

  • Check message moved to 2nd argument of PHP_ARG_WITH
  • AH_TEMPLATE takes care of help message defined on one place for both defines
  • AS_VAR_IF used and CS sycned a bit
  • Cache variables renamed to php_cv_*
  • Redundant AC_CANONICAL_HOST call removed. The host_cpu is set together with a triplet in PHP_CANONICAL_HOST_TARGET
  • Over-quoted arguments reduced

@petk
Autotools: Refactor PCRE JIT checks
b70f225 
- Check message moved to 2nd argument of PHP_ARG_WITH
- AH_TEMPLATE takes care of help message defined on one place for both
  defines
- AS_VAR_IF used and CS sycned a bit
- Cache variables renamed to php_cv_*
- Redundant AC_CANONICAL_HOST call removed. The host_cpu is set together
  with a triplet in PHP_CANONICAL_HOST_TARGET
- Over-quoted arguments reduced
@petk petk merged commit 063213b into php:master Jul 3, 2024
11 checks passed
@petk petk deleted the patch-cache-variables-pcre branch July 3, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devnexen devnexen devnexen approved these changes

Assignees
No one assigned
Labels
Category: Build System Extension: pcre
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petk @devnexen