Fix FPM status json encoded value test #11276
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bukka
force-pushed
the
fpm_status_json_field_test
branch
from
95e64ca to
5178b84
Compare
|
@iluuu1994 That should fix the failure that you reported. @andypost Not sure however if this is going to fix the issue that you reported so if you could give it a try that would be appreciated. |
bukka
force-pushed
the
fpm_status_json_field_test
branch
from
5178b84 to
e3d11fd
Compare
iluuu1994
approved these changes
May 19, 2023
| ); | ||
| } | ||
| foreach ($data['processes'] as $process) { | ||
| if (preg_match('/' . $pattern . '/', $process[$fieldName]) !== false) { |
There was a problem hiding this comment.
I recommend using () as the delimiter so that the caller doesn't need to escape / or any other literal character.
There was a problem hiding this comment.
Is it for compatibility with Windows?
There was a problem hiding this comment.
Ah yeah will use pipes in case it was used for matching the whole uri...
There was a problem hiding this comment.
I'm actually using pipes elsewhere - not sure why I used slashes here...
|
Confirm the last change fixed the test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the failure when incorrect process is selected. As it is a static pool, it can be in any process so we cannot expect that process 0 is the query one.