Use an explicit failure check for zend_result functions in the scanner #10688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would actually also be more accurate to what the code is currently doing, but I checked and |
|
I can change them, I don't have a preference myself. Shall I change both? |
|
Sure, let's change it then. |
nielsdos
force-pushed
the
zend-result-1
branch
from
d0740d3 to
fde827d
Compare
|
Updated. Thx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small cleanup.
Instead of an implicit check, use an explicit failure check.
(A check against != SUCCESS would probably result in slightly nicer assembly, but I doubt that matters at all and it doesn't seem to be the style.)