Skip to content

Fix zend_fcc_equals() with trampolines #10012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2022
Merged

Fix zend_fcc_equals() with trampolines #10012

merged 1 commit into from
Dec 2, 2022

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Nov 28, 2022

We cannot compare the function handler pointer directly for trampolines, as they may be reallocated.

Found while working on #8294

@Girgias
Fix zend_fcc_equals() with trampolines
d573449 
We cannot compare the function handler pointer directly for trampolines, as they may be reallocated
@Girgias Girgias requested a review from arnaud-lb November 28, 2022 05:20
@Girgias Girgias merged commit c4a0fc6 into php:master Dec 2, 2022
@Girgias Girgias deleted the fcc-equals-fix branch December 2, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnaud-lb arnaud-lb arnaud-lb approved these changes

Assignees
No one assigned
Labels
Category: Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Girgias @arnaud-lb