Use is_numeric_string_ex() to avoid mislabelling numeric strings as non-numeric

rizwan3d · rizwan3d · commit 9152f3bad902 · 2025-12-04T11:33:01.000-05:00
diff --git a/Zend/zend_API.c b/Zend/zend_API.c
@@ -160,6 +160,14 @@ ZEND_API const char *zend_zval_numeric_string_value_name(const zval *arg)
             return "empty-string";
         }
 
+		zend_long lval;
+        double dval;
+
+        if (is_numeric_string_ex(Z_STRVAL_P(val), Z_STRLEN_P(val),&lval, &dval, 0, NULL)) 
+		{
+            return "string";
+        }
+
         return "non-numeric-string";
     }
 

Original file line number	Diff line number	Diff line change
`@@ -160,6 +160,14 @@ ZEND_API const char zend_zval_numeric_string_value_name(const zval arg)`
`160`	`160`	`return "empty-string";`
`161`	`161`	`}`
`162`	`162`
	`163`	`+ zend_long lval;`
	`164`	`+ double dval;`
	`165`	`+`
	`166`	`+ if (is_numeric_string_ex(Z_STRVAL_P(val), Z_STRLEN_P(val),&lval, &dval, 0, NULL))`
	`167`	`+ {`
	`168`	`+ return "string";`
	`169`	`+ }`
	`170`	`+`
`163`	`171`	`return "non-numeric-string";`
`164`	`172`	`}`
`165`	`173`