Skip to content

Commit 83fea2c

Browse files
kooldevbeberlei
kooldev
authored and
beberlei
committed
Aligned scope resolution code. Added closure scope and rebind testing.
1 parent 1a270b2 commit 83fea2c

File tree

4 files changed

+92
-45
lines changed

4 files changed

+92
-45
lines changed

Zend/tests/attributes/013_scope_resolution.phpt renamed to Zend/tests/attributes/013_class_scope.phpt

Lines changed: 21 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
--TEST--
2-
Attributes make use of correct scope.
2+
Attributes make use of class scope.
33
--FILE--
44
<?php
55

@@ -25,20 +25,21 @@ print_r($ref->getMethod('bar')->getParameters()[0]->getAttributes()[0]->getArgum
2525

2626
echo "\n";
2727

28-
class C2
28+
trait T1
2929
{
30-
private const FOO = 'foo';
31-
32-
public static function foo()
33-
{
34-
return <<A1(self::class, self::FOO)>> function (<<A1(self::class, self::FOO)>> $p) { };
35-
}
30+
<<A1(self::class, self::FOO)>>
31+
public function foo() { }
3632
}
3733

38-
$ref = new \ReflectionFunction(C2::foo());
39-
print_r($ref->getAttributes()[0]->getArguments());
40-
print_r($ref->getParameters()[0]->getAttributes()[0]->getArguments());
34+
class C2
35+
{
36+
use T1;
37+
38+
private const FOO = 'bar';
39+
}
4140

41+
$ref = new \ReflectionClass(C2::class);
42+
print_r($ref->getMethod('foo')->getAttributes()[0]->getArguments());
4243
echo "\n";
4344

4445
class C3
@@ -56,13 +57,13 @@ class C3
5657
}
5758
}
5859

59-
$obj = C3::foo();
60-
$ref = new \ReflectionObject($obj);
61-
$name = $ref->getMethod('bar')->getAttributes()[0]->getArguments()[0];
60+
$ref = new \ReflectionObject(C3::foo());
6261

63-
print_r($ref->getAttributes()[0]->getArguments());
64-
var_dump($name == get_class($obj));
65-
var_dump($ref->getMethod('bar')->getAttributes()[0]->getArguments()[1]);
62+
$args = $ref->getAttributes()[0]->getArguments();
63+
var_dump($args[0] == $ref->getName(), $args[1]);
64+
65+
$args = $ref->getMethod('bar')->getAttributes()[0]->getArguments();
66+
var_dump($args[0] == $ref->getName(), $args[1]);
6667

6768
?>
6869
--EXPECT--
@@ -95,18 +96,10 @@ Array
9596
Array
9697
(
9798
[0] => C2
98-
[1] => foo
99-
)
100-
Array
101-
(
102-
[0] => C2
103-
[1] => foo
99+
[1] => bar
104100
)
105101

106-
Array
107-
(
108-
[0] => C3
109-
[1] => foo
110-
)
102+
bool(true)
103+
string(3) "bar"
111104
bool(true)
112105
string(3) "bar"

‎Zend/tests/attributes/017_closure_scope.phpt‎

Lines changed: 53 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,53 @@
1+
--TEST--
2+
Attributes make use of closure scope.
3+
--FILE--
4+
<?php
5+
6+
class Test1
7+
{
8+
private const FOO = 'bar';
9+
}
10+
11+
class C1
12+
{
13+
private const FOO = 'foo';
14+
15+
public static function foo()
16+
{
17+
return <<A1(self::class, self::FOO)>> function (<<A1(self::class, self::FOO)>> $p) { };
18+
}
19+
}
20+
21+
$ref = new \ReflectionFunction(C1::foo());
22+
print_r($ref->getAttributes()[0]->getArguments());
23+
print_r($ref->getParameters()[0]->getAttributes()[0]->getArguments());
24+
25+
echo "\n";
26+
27+
$ref = new \ReflectionFunction(C1::foo()->bindTo(null, Test1::class));
28+
print_r($ref->getAttributes()[0]->getArguments());
29+
print_r($ref->getParameters()[0]->getAttributes()[0]->getArguments());
30+
31+
?>
32+
--EXPECT--
33+
Array
34+
(
35+
[0] => C1
36+
[1] => foo
37+
)
38+
Array
39+
(
40+
[0] => C1
41+
[1] => foo
42+
)
43+
44+
Array
45+
(
46+
[0] => Test1
47+
[1] => bar
48+
)
49+
Array
50+
(
51+
[0] => Test1
52+
[1] => bar
53+
)

‎Zend/zend_compile.c‎

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1046,10 +1046,6 @@ ZEND_API void function_add_ref(zend_function *function) /* {{{ */
10461046
ZEND_MAP_PTR_INIT(op_array->run_time_cache, zend_arena_alloc(&CG(arena), sizeof(void*)));
10471047
ZEND_MAP_PTR_SET(op_array->run_time_cache, NULL);
10481048
}
1049-
1050-
if (op_array->attributes) {
1051-
GC_ADDREF(op_array->attributes);
1052-
}
10531049
}
10541050

10551051
if (function->common.function_name) {
@@ -6370,15 +6366,7 @@ void zend_compile_func_decl(znode *result, zend_ast *ast, zend_bool toplevel) /*
63706366
if (decl->doc_comment) {
63716367
op_array->doc_comment = zend_string_copy(decl->doc_comment);
63726368
}
6373-
if (decl->child[4]) {
6374-
int target = ZEND_ATTRIBUTE_TARGET_FUNCTION;
63756369

6376-
if (is_method) {
6377-
target = ZEND_ATTRIBUTE_TARGET_METHOD;
6378-
}
6379-
op_array->attributes = create_attribute_array();
6380-
zend_compile_attributes(op_array->attributes, decl->child[4], 0, target);
6381-
}
63826370
if (decl->kind == ZEND_AST_CLOSURE || decl->kind == ZEND_AST_ARROW_FUNC) {
63836371
op_array->fn_flags |= ZEND_ACC_CLOSURE;
63846372
}
@@ -6398,6 +6386,17 @@ void zend_compile_func_decl(znode *result, zend_ast *ast, zend_bool toplevel) /*
63986386

63996387
CG(active_op_array) = op_array;
64006388

6389+
if (decl->child[4]) {
6390+
int target = ZEND_ATTRIBUTE_TARGET_FUNCTION;
6391+
6392+
if (is_method) {
6393+
target = ZEND_ATTRIBUTE_TARGET_METHOD;
6394+
}
6395+
6396+
op_array->attributes = create_attribute_array();
6397+
zend_compile_attributes(op_array->attributes, decl->child[4], 0, target);
6398+
}
6399+
64016400
/* Do not leak the class scope into free standing functions, even if they are dynamically
64026401
* defined inside a class method. This is necessary for correct handling of magic constants.
64036402
* For example __CLASS__ should always be "" inside a free standing function. */
@@ -6823,10 +6822,6 @@ void zend_compile_class_decl(znode *result, zend_ast *ast, zend_bool toplevel) /
68236822
if (decl->doc_comment) {
68246823
ce->info.user.doc_comment = zend_string_copy(decl->doc_comment);
68256824
}
6826-
if (decl->child[4]) {
6827-
ce->attributes = create_attribute_array();
6828-
zend_compile_attributes(ce->attributes, decl->child[4], 0, ZEND_ATTRIBUTE_TARGET_CLASS);
6829-
}
68306825

68316826
if (UNEXPECTED((decl->flags & ZEND_ACC_ANON_CLASS))) {
68326827
/* Serialization is not supported for anonymous classes */
@@ -6841,6 +6836,11 @@ void zend_compile_class_decl(znode *result, zend_ast *ast, zend_bool toplevel) /
68416836

68426837
CG(active_class_entry) = ce;
68436838

6839+
if (decl->child[4]) {
6840+
ce->attributes = create_attribute_array();
6841+
zend_compile_attributes(ce->attributes, decl->child[4], 0, ZEND_ATTRIBUTE_TARGET_CLASS);
6842+
}
6843+
68446844
if (implements_ast) {
68456845
zend_compile_implements(implements_ast);
68466846
}

‎ext/reflection/php_reflection.c‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6411,8 +6411,9 @@ ZEND_METHOD(ReflectionAttribute, getName)
64116411
static zend_always_inline int import_attribute_value(zval *ret, zval *val, zend_class_entry *scope) /* {{{ */
64126412
{
64136413
ZVAL_COPY_OR_DUP(ret, val);
6414+
64146415
if (Z_TYPE_P(val) == IS_CONSTANT_AST) {
6415-
if (FAILURE == zval_update_constant_ex(ret, scope)) {
6416+
if (SUCCESS != zval_update_constant_ex(ret, scope)) {
64166417
zval_ptr_dtor(ret);
64176418
return FAILURE;
64186419
}

0 commit comments

Comments
 (0)