Skip to content

Commit 37e61a0

Browse files
committed
sapi/phpdbg: fixed ZPP type violation by using 'h' ZPP specifier instead of 'H'
This aligns the behaviour with what the stubs say. And even if one fixes the stubs the behaviour is not identical due to missing indirect handling. This indicates that using objects is never done, so do the easy fix of changing the ZPP specifier. Closes GH-20465
2 parents 8ad5915 + 414e7db commit 37e61a0

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

NEWS

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,10 @@ PHP NEWS
2222
. Fixed bug GH-20442 (Phar does not respect case-insensitiveness of
2323
__halt_compiler() when reading stub). (ndossche, TimWolla)
2424

25+
- PHPDBG:
26+
. Fixed ZPP type violation in phpdbg_get_executable() and phpdbg_end_oplog().
27+
(Girgias)
28+
2529
- Standard:
2630
. Fix memory leak in array_diff() with custom type checks. (ndossche)
2731

sapi/phpdbg/phpdbg.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -491,7 +491,7 @@ PHP_FUNCTION(phpdbg_get_executable)
491491
HashTable *files = &PHPDBG_G(file_sources);
492492
HashTable files_tmp;
493493

494-
if (zend_parse_parameters(ZEND_NUM_ARGS(), "|H", &options) == FAILURE) {
494+
if (zend_parse_parameters(ZEND_NUM_ARGS(), "|h", &options) == FAILURE) {
495495
RETURN_THROWS();
496496
}
497497

@@ -585,7 +585,7 @@ PHP_FUNCTION(phpdbg_end_oplog)
585585
bool by_function = 0;
586586
bool by_opcode = 0;
587587

588-
if (zend_parse_parameters(ZEND_NUM_ARGS(), "|H", &options) == FAILURE) {
588+
if (zend_parse_parameters(ZEND_NUM_ARGS(), "|h", &options) == FAILURE) {
589589
RETURN_THROWS();
590590
}
591591

0 commit comments

Comments
 (0)