github: fix static workflows update dependencies #516
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gimler
force-pushed
the
feature/github-actions
branch
from
09e2295 to
33fad81
Compare
gimler
force-pushed
the
feature/github-actions
branch
from
33fad81 to
f80e59f
Compare
|
@bocharsky-bw can you take a look please? Only one small point is broken. |
gimler
force-pushed
the
feature/github-actions
branch
from
4f6e3c5 to
f80e59f
Compare
|
@bocharsky-bw all green |
gimler
force-pushed
the
feature/github-actions
branch
from
d6f4937 to
c036d64
Compare
rvanlaak
approved these changes
Mar 27, 2025
There was a problem hiding this comment.
@bocharsky-bw I'm okay with dropping Twig 2 support together with this PR to fix tests and releasing it as minor, as the last 2.x release was on Sep 9, 2024 and not many features get added to this bundle either way.
|
Sounds good to me 👍 Thank you, guys! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nodes since 3.15.0 https://github.com/twigphp/Twig/blob/3.x/CHANGELOG#L89
ConditionalTernary since 3.17.0 https://github.com/twigphp/Twig/blob/3.x/CHANGELOG#L57
The
Tests/Unit/Twig/DefaultApplyingNodeVisitorTest.phptest produce different parse output in ci matrix lowest&highest.Solution:
A. we blow up the code base with if conditions and check which class is available
B. we increase the minimum supported twig level
I prefer B. We should increase the minimum twig version and keep the code base clean.