Skip to content

Commit f79648e

Browse files
authored
Made classes final and added docs (#23)
* Made classes final * style ci * Added branch alias
1 parent 93b2f54 commit f79648e

32 files changed

+117
-24
lines changed

Changelog.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,12 @@
22

33
The change log describes what is "Added", "Removed", "Changed" or "Fixed" between each release.
44

5-
## UNRELEASED
5+
## 1.0.0
66

77
## Added
88

99
- Extractor for classes implementing `TranslationSourceLocationContainer`
10+
- Made classes final
1011

1112
## 0.1.1
1213

composer.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,11 @@
3232
"scripts": {
3333
"test": "vendor/bin/phpunit",
3434
"test-ci": "vendor/bin/phpunit --coverage-text --coverage-clover=build/coverage.xml"
35+
},
36+
"extra": {
37+
"branch-alias": {
38+
"dev-master": "1.0-dev"
39+
}
3540
}
3641
}
3742

src/Extractor.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,13 @@
1616
use Translation\Extractor\FileExtractor\FileExtractor;
1717
use Translation\Extractor\Model\SourceCollection;
1818

19-
class Extractor
19+
/**
20+
* Main class for all extractors. This is the service that will be loaded with file
21+
* extractors.
22+
*
23+
* @author Tobias Nyholm <[email protected]>
24+
*/
25+
final class Extractor
2026
{
2127
/**
2228
* @var FileExtractor[]

src/FileExtractor/BladeFileExtractor.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
/**
1919
* @author Tobias Nyholm <[email protected]>
2020
*/
21-
class BladeFileExtractor implements FileExtractor
21+
final class BladeFileExtractor implements FileExtractor
2222
{
2323
public function getSourceLocations(SplFileInfo $file, SourceCollection $collection)
2424
{

src/FileExtractor/PHPFileExtractor.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
/**
2323
* @author Tobias Nyholm <[email protected]>
2424
*/
25-
class PHPFileExtractor implements FileExtractor
25+
final class PHPFileExtractor implements FileExtractor
2626
{
2727
/**
2828
* @var Visitor[]|NodeVisitor[]

src/FileExtractor/TwigFileExtractor.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
/**
1919
* @author Tobias Nyholm <[email protected]>
2020
*/
21-
class TwigFileExtractor implements FileExtractor
21+
final class TwigFileExtractor implements FileExtractor
2222
{
2323
/**
2424
* @var Visitor[]|\Twig_NodeVisitorInterface[]

src/Visitor/BaseVisitor.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,11 @@
1414
use Symfony\Component\Finder\SplFileInfo;
1515
use Translation\Extractor\Model\SourceCollection;
1616

17+
/**
18+
* Base class for any visitor.
19+
*
20+
* @author Tobias Nyholm <[email protected]>
21+
*/
1722
abstract class BaseVisitor implements Visitor
1823
{
1924
/**

src/Visitor/Php/BasePHPVisitor.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,11 @@
1414
use PhpParser\Node;
1515
use Translation\Extractor\Visitor\BaseVisitor;
1616

17+
/**
18+
* Base class for PHP visitors.
19+
*
20+
* @author Tobias Nyholm <[email protected]>
21+
*/
1722
abstract class BasePHPVisitor extends BaseVisitor
1823
{
1924
/**

src/Visitor/Php/SourceLocationContainerVisitor.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
*
2222
* @author Tobias Nyholm <[email protected]>
2323
*/
24-
class SourceLocationContainerVisitor extends BasePHPVisitor implements NodeVisitor
24+
final class SourceLocationContainerVisitor extends BasePHPVisitor implements NodeVisitor
2525
{
2626
/**
2727
* @var string

src/Visitor/Php/Symfony/ContainerAwareTrans.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,10 @@
1616
use Translation\Extractor\Model\SourceLocation;
1717
use Translation\Extractor\Visitor\Php\BasePHPVisitor;
1818

19-
class ContainerAwareTrans extends BasePHPVisitor implements NodeVisitor
19+
/**
20+
* @author Tobias Nyholm <[email protected]>
21+
*/
22+
final class ContainerAwareTrans extends BasePHPVisitor implements NodeVisitor
2023
{
2124
public function beforeTraverse(array $nodes)
2225
{

0 commit comments

Comments
 (0)