Autoselect SystemCommand from existing Commands #940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove all dummy commands from library. This may break backwards compat!!
noplanman
force-pushed
the
920-new_system_commands
branch
from
8add74e to
da604d8
Compare
|
Maybe we could add deprecation notice into generic one to notify people about this change? |
|
@jacklul Perfect, I'll do that then for now. At some point they'll be removed completely though. |
jacklul
approved these changes
Mar 23, 2019
…erve backwards compatibility.
noplanman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested by @jacklul here: #920 (comment)
Message field types can now automatically choose which command class gets loaded to execute.
If none is defined, GenericmessageCommand is executed by default.
Removed all empty dummy SystemCommands from library.
❗ This can create problems for any project that does not specifically implement SystemCommands that handle all different types, as now GenericmessageCommand gets called for all of them, whereas before they would just be handled silently.
For this reason, SystemCommands must now either be dummied specifically, or GenericmessageCommand must handle the conditions to work correctly.
@jacklul What do you think, does this make sense? Or should we leave the current dummies as they are to preserve backwards compatibility and minimise any possible breakage?
Overrules and closes #921
Fixes #920