Skip to content

WIP: Refactor app design #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 40 commits into from
Closed

Conversation

akalongman
Copy link
Member

@akalongman akalongman commented Apr 21, 2018

I am still working on this but want to discuss some implementation details.

I want divide responsibilities of classes and make the structure more easy to understand.

This PR contains:

  • Minimum supported PHP version increased to 5.6.4
  • Add Container support and dependency injection
  • Rename old Request class to Client for making HTTP requests
  • Introduce HTTP Kernel and Request classes

@php-telegram-bot/developers I want to hear your thoughts

Related issue #826

@akalongman akalongman self-assigned this Apr 21, 2018
@akalongman akalongman requested a review from a team April 21, 2018 14:01
@akalongman akalongman changed the title [WIP] Refactor app design WIP: Refactor app design Apr 21, 2018
@akalongman
Copy link
Member Author

This PR is outdated. I will send another

@akalongman akalongman closed this Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant