Skip to content

Commit f52864a

Browse files
veeweeveewee
committed
Introduce a XsiTypeCalculator feature that can enhance xsi:type calculation from the encoder
1 parent abbf352 commit f52864a

File tree

5 files changed

+93
-7
lines changed

5 files changed

+93
-7
lines changed

‎examples/encoders/simpleType/anyType-with-xsi-info.php‎

Lines changed: 22 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,11 @@
33

44
use Soap\Encoding\Encoder\Context;
55
use Soap\Encoding\Encoder\Feature\ElementContextEnhancer;
6+
use Soap\Encoding\Encoder\Feature\XsiTypeCalculator;
67
use Soap\Encoding\Encoder\SimpleType\ScalarTypeEncoder;
78
use Soap\Encoding\Encoder\XmlEncoder;
89
use Soap\Encoding\EncoderRegistry;
10+
use Soap\Encoding\TypeInference\XsiTypeDetector;
911
use Soap\WsdlReader\Model\Definitions\BindingUse;
1012
use VeeWee\Reflecta\Iso\Iso;
1113

@@ -31,7 +33,8 @@
3133
'anyType',
3234
new class implements
3335
ElementContextEnhancer,
34-
XmlEncoder {
36+
XmlEncoder,
37+
XsiTypeCalculator {
3538
public function iso(Context $context): Iso
3639
{
3740
return (new ScalarTypeEncoder())->iso($context);
@@ -45,5 +48,23 @@ public function enhanceElementContext(Context $context): Context
4548
{
4649
return $context->withBindingUse(BindingUse::ENCODED);
4750
}
51+
52+
/**
53+
* Can be used to fine-tune the xsi:type element.
54+
* For example, xsi:type="xsd:date" when dealing with value's like `DateTimeImmutable`.
55+
*/
56+
public function resolveXsiTypeForValue(Context $context, mixed $value): string
57+
{
58+
return XsiTypeDetector::detectFromValue($context, $value);
59+
}
60+
61+
/**
62+
* Determines if the xmlns of the xsi:type prefix should be imported.
63+
* For example: xsd:date will import xmlns:xsd="...".
64+
*/
65+
public function shouldIncludeXsiTargetNamespace(Context $context): bool
66+
{
67+
return true;
68+
}
4869
}
4970
);

‎src/Encoder/Feature/DisregardXsiInformation.php‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,10 @@
33

44
namespace Soap\Encoding\Encoder\Feature;
55

6+
/**
7+
* Tells the decoder to disregard any xsi:type information on the element when decoding an element.
8+
* It will use the original provided decoder by default and won't try to guess the decoder based on xsi:type.
9+
*/
610
interface DisregardXsiInformation
711
{
812
}

‎src/Encoder/Feature/XsiTypeCalculator.php‎

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,23 @@
1+
<?php
2+
declare(strict_types=1);
3+
4+
namespace Soap\Encoding\Encoder\Feature;
5+
6+
use Soap\Encoding\Encoder\Context;
7+
8+
/**
9+
* By implementing this feature on your simpleType encoder, you can let the encoder decide what xsi:type attribute should be set to for a given value.
10+
*/
11+
interface XsiTypeCalculator
12+
{
13+
/**
14+
* @return string The value for the xsi:type attribute
15+
*/
16+
public function resolveXsiTypeForValue(Context $context, mixed $value): string;
17+
18+
19+
/**
20+
* Tells the XsiAttributeBuilder that the prefix of the xsi:type should be imported as a xmlns namespace.
21+
*/
22+
public function shouldIncludeXsiTargetNamespace(Context $context): bool;
23+
}

‎src/Xml/Writer/ElementValueBuilder.php‎

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
use Generator;
77
use Soap\Encoding\Encoder\Context;
8-
use Soap\Encoding\Encoder\Feature\CData;
8+
use Soap\Encoding\Encoder\Feature;
99
use Soap\Encoding\Encoder\XmlEncoder;
1010
use Soap\Encoding\TypeInference\XsiTypeDetector;
1111
use Soap\WsdlReader\Model\Definitions\BindingUse;
@@ -49,12 +49,18 @@ private function buildXsiType(XMLWriter $writer): Generator
4949

5050
$context = $this->context;
5151
$type = $context->type;
52+
$xsiType = $this->encoder instanceof Feature\XsiTypeCalculator
53+
? $this->encoder->resolveXsiTypeForValue($context, $this->value)
54+
: XsiTypeDetector::detectFromValue($context, $this->value);
55+
$includeXsiTargetNamespace = $this->encoder instanceof Feature\XsiTypeCalculator
56+
? $this->encoder->shouldIncludeXsiTargetNamespace($context)
57+
: $type->getXmlTargetNamespace() !== $type->getXmlNamespace()
58+
|| !$type->getMeta()->isQualified()->unwrapOr(false);
5259

5360
yield from (new XsiAttributeBuilder(
5461
$this->context,
55-
XsiTypeDetector::detectFromValue($context, $this->value),
56-
includeXsiTargetNamespace: $type->getXmlTargetNamespace() !== $type->getXmlNamespace()
57-
|| !$type->getMeta()->isQualified()->unwrapOr(false)
62+
$xsiType,
63+
$includeXsiTargetNamespace,
5864
))($writer);
5965
}
6066

@@ -66,7 +72,7 @@ private function buildValue(XMLWriter $writer): Generator
6672
$encoded = $this->encoder->iso($this->context)->to($this->value);
6773

6874
$builder = match (true) {
69-
$this->encoder instanceof CData => cdata(value($encoded)),
75+
$this->encoder instanceof Feature\CData => cdata(value($encoded)),
7076
default => value($encoded)
7177
};
7278

‎tests/Unit/Encoder/ElementEncoderTest.php‎

Lines changed: 33 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,14 @@
77
use Soap\Encoding\Encoder\Context;
88
use Soap\Encoding\Encoder\ElementEncoder;
99
use Soap\Encoding\Encoder\Feature\ElementContextEnhancer;
10+
use Soap\Encoding\Encoder\Feature\XsiTypeCalculator;
1011
use Soap\Encoding\Encoder\SimpleType\IntTypeEncoder;
1112
use Soap\Encoding\Encoder\SimpleType\StringTypeEncoder;
1213
use Soap\Encoding\Encoder\XmlEncoder;
1314
use Soap\Encoding\Xml\Node\Element;
1415
use Soap\Engine\Metadata\Model\TypeMeta;
1516
use Soap\Engine\Metadata\Model\XsdType;
17+
use Soap\WsdlReader\Model\Definitions\BindingUse;
1618
use VeeWee\Reflecta\Iso\Iso;
1719

1820
#[CoversClass(ElementEncoder::class)]
@@ -25,7 +27,11 @@ public static function provideIsomorphicCases(): iterable
2527
'context' => $context = self::createContext(
2628
$xsdType = XsdType::guess('string')
2729
->withXmlTargetNodeName('hello')
28-
->withMeta(static fn (TypeMeta $meta): TypeMeta => $meta->withIsQualified(true))
30+
->withMeta(
31+
static fn (TypeMeta $meta): TypeMeta => $meta
32+
->withIsQualified(true)
33+
->withIsSimple(true)
34+
)
2935
),
3036
];
3137

@@ -79,6 +85,32 @@ public function enhanceElementContext(Context $context): Context
7985
'xml' => '<bonjour>32</bonjour>',
8086
'data' => 32,
8187
];
88+
yield 'xsi-type-calculating-encoder' => [
89+
...$baseConfig,
90+
'encoder' => $encoder = new ElementEncoder(new class implements ElementContextEnhancer, XmlEncoder, XsiTypeCalculator {
91+
public function iso(Context $context): Iso
92+
{
93+
return (new IntTypeEncoder())->iso($context);
94+
}
95+
96+
public function enhanceElementContext(Context $context): Context
97+
{
98+
return $context->withBindingUse(BindingUse::ENCODED);
99+
}
100+
101+
public function resolveXsiTypeForValue(Context $context, mixed $value): string
102+
{
103+
return 'xsd:'.get_debug_type($value);
104+
}
105+
106+
public function shouldIncludeXsiTargetNamespace(Context $context): bool
107+
{
108+
return true;
109+
}
110+
}),
111+
'xml' => '<hello xmlns:xsd="http://www.w3.org/2001/XMLSchema" xsi:type="xsd:int" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">32</hello>',
112+
'data' => 32,
113+
];
82114
}
83115

84116
public function test_it_can_decode_from_xml_item(): void

0 commit comments

Comments
 (0)