Skip to content

Unite the types #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jun 7, 2021
Merged

Unite the types #20

merged 14 commits into from
Jun 7, 2021

Conversation

AydinHassan
Copy link
Member

@AydinHassan AydinHassan commented Jun 5, 2021

@AydinHassan
Copy link
Member Author

@mikeymike do you think there is anything else I should test here? I think that the adding and calling the method is kinda covered by the output check?

@mikeymike
Copy link
Member

yeah agreed, checks look good to me 👍

@AydinHassan AydinHassan changed the title Unite the types WIP Unite the types Jun 6, 2021
@AydinHassan AydinHassan marked this pull request as ready for review June 6, 2021 10:11
@AydinHassan AydinHassan requested a review from mikeymike June 6, 2021 10:11
@codecov-commenter
Copy link

Codecov Report

Merging #20 (9f3e1f6) into master (493a567) will decrease coverage by 1.25%.
The diff coverage is 87.64%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #20      +/-   ##
============================================
- Coverage     91.57%   90.32%   -1.26%     
- Complexity       64       90      +26     
============================================
  Files             4        6       +2     
  Lines           190      279      +89     
============================================
+ Hits            174      252      +78     
- Misses           16       27      +11     
Impacted Files Coverage Δ
src/Exercise/LordOfTheStrings.php 72.72% <72.72%> (ø)
src/Exercise/UniteTheTypes.php 96.42% <96.42%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 493a567...9f3e1f6. Read the comment docs.

@AydinHassan AydinHassan merged commit 501df7d into master Jun 7, 2021
@AydinHassan AydinHassan deleted the unite-the-types branch June 7, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants