-
Notifications
You must be signed in to change notification settings - Fork 0
Unite the types #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unite the types #20
Conversation
@mikeymike do you think there is anything else I should test here? I think that the adding and calling the method is kinda covered by the output check? |
802c719
to
b1dc1ad
Compare
yeah agreed, checks look good to me 👍 |
d7b3b8d
to
9f3e1f6
Compare
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
============================================
- Coverage 91.57% 90.32% -1.26%
- Complexity 64 90 +26
============================================
Files 4 6 +2
Lines 190 279 +89
============================================
+ Hits 174 252 +78
- Misses 16 27 +11
Continue to review full report at Codecov.
|
9f3e1f6
to
9b70bdd
Compare
Needs:
php-school/php-workshop#219
php-school/php-workshop#220