Skip to content

Allow attaching to multiple events at same time #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 30, 2016
Merged

Allow attaching to multiple events at same time #87

merged 2 commits into from
Jan 30, 2016

Conversation

AydinHassan
Copy link
Member

No description provided.

@AydinHassan AydinHassan self-assigned this Jan 30, 2016
@AydinHassan AydinHassan added this to the RC1 milestone Jan 30, 2016
@codecov-io
Copy link

Current coverage is 89.86%

Merging #87 into master will increase coverage by +0.05% as of d216fce

@@            master     #87   diff @@
======================================
  Files           69      69       
  Stmts         1669    1677     +8
  Branches         0       0       
  Methods        274     275     +1
======================================
+ Hit           1499    1507     +8
  Partial          0       0       
  Missed         170     170

Review entire Coverage Diff as of d216fce

Powered by Codecov. Updated on successful CI builds.

mikeymike
mikeymike reviewed Jan 30, 2016
View reviewed changes
src/Event/EventDispatcher.php
@@ -65,10 +65,25 @@ public function dispatch(EventInterface $event)
}

/**
* @param string $eventNames
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string|array ;)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, cheers!

@mikeymike
Copy link
Member

Nice addition 👍

AydinHassan added a commit that referenced this pull request Jan 30, 2016
@AydinHassan
Merge pull request #87 from php-school/attach-to-multiple-events
a270cf8 
Allow attaching to multiple events at same time
@AydinHassan AydinHassan merged commit a270cf8 into master Jan 30, 2016
@AydinHassan AydinHassan deleted the attach-to-multiple-events branch January 30, 2016 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AydinHassan AydinHassan

Labels
enhancement
Projects
None yet
Milestone
RC1
Development

Successfully merging this pull request may close these issues.
3 participants
@AydinHassan @codecov-io @mikeymike